A bit too much bikeshedding (this crappy EDID code usually doesn't
deserve my attention) but ignoring what dark corner this is about:
we can do better ;)

View Change

1 comment:

• File src/lib/edid.c:

  • Patch Set #1, Line 207: #if CONFIG_DEFAULT_CONSOLE_LOGLEVEL > 8

    `> 8` means BIOS_NEVER. Probably not the intention, writing
    `> BIOS_SPEW` would have made that obvious :-P

    Also I see no real benefit of an #if at all. It's ramstage
    code (we don't have to save every single byte in flash) and it
    doesn't have side effects (beside the potential log output).
    And, anyway, you could write it in C and it would still be
    dropped from the binary in case:

        if (IS_ENABLED(CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8)) {

To view, visit change 28872. To unsubscribe, or for help writing mail filters, visit settings.