Change in coreboot[master]: soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication

[John Zhao (Code Review)]

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47656 )

Change subject: soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication
......................................................................

soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication

There is a ACPI error message about no handler or method for GPE73 while
plugging a USB3 flash driver to a type-C-to-A dongle. The PMC_GPE0_DW2
is routed to GPP_E and GPP_E9/USB_OC0# is mapped to GPE73. This change
adds a dummy GPE Method _L73 for USB overcurrent indication. Kernel
driver suspends the bus and host controller which avoids the host halted
in USB overcurrent state.

BUG=b:155158498;173054070
TEST=Built images for Voxel and Delbin boards. Verified GPE73 is enabled
and unmasked. There is no handler or method error message for GPE73
while plugging a USB3 flash driver to a type-C-to-A dongle.

Signed-off-by: John Zhao 
Change-Id: I25fca6de44ce5c513fb6f7c4cfe46c5b7686fb20
---
M src/soc/intel/tigerlake/acpi/tcss.asl
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/47656/1

diff --git a/src/soc/intel/tigerlake/acpi/tcss.asl b/src/soc/intel/tigerlake/acpi/tcss.asl
index 9893833..d888e86 100644
--- a/src/soc/intel/tigerlake/acpi/tcss.asl
+++ b/src/soc/intel/tigerlake/acpi/tcss.asl
@@ -311,6 +311,12 @@
    	_SB.PCI0.TRP2.HPME()
    	_SB.PCI0.TRP3.HPME()
    }
+
+	/* USB_OC0# */
+	Method(_L73, 0 , serialized)
+	{
+		Printf("USB Overcurrent Indicator");
+	}
 }

Scope (_SB.PCI0)

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47656 )

Change subject: soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47656/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47656/1//COMMIT_MSG@9 
PS1, Line 9: There is a ACPI error message about no handler or method for GPE73 while
           : plugging a USB3 flash driver to a type-C-to-A dongle. The PMC_GPE0_DW2
           : is routed to GPP_E and GPP_E9/USB_OC0# is mapped to GPE73. This change
           : adds a dummy GPE Method _L73 for USB overcurrent indication. Kernel
           : driver suspends the bus and host controller which avoids the host halted
           : in USB overcurrent state.
This is really strange... I wonder if there's a bug in the kernel. The comment above the line where the error msg is printed says:
```
                /*
                 * No handler or method to run!
                 * 03/2010: This case should no longer be possible. We will not allow
                 * a GPE to be enabled if it has no handler or method.
                 */

```

So for some reason the GPE is enabled even though there is no handler for it.

[John Zhao (Code Review)]

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47656 )

Change subject: soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47656/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47656/1//COMMIT_MSG@9 
PS1, Line 9: There is a ACPI error message about no handler or method for GPE73 while
           : plugging a USB3 flash driver to a type-C-to-A dongle. The PMC_GPE0_DW2
           : is routed to GPP_E and GPP_E9/USB_OC0# is mapped to GPE73. This change
           : adds a dummy GPE Method _L73 for USB overcurrent indication. Kernel
           : driver suspends the bus and host controller which avoids the host halted
           : in USB overcurrent state.
> This is really strange... I wonder if there's a bug in the kernel. […]

This patch is only intended to address the ACPI error message. Other platforms like Windows has the same dummy _L73 method implementation. 
The observation shows pch xhci is not enumerated as USB2 device when IOM port state is TCCOLD. There is debugging activity for the issue.

[XS] Change in coreboot[master]: soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/47656?usp=email )

Change subject: soc/intel/tigerlake: Add Method _L73 for USB overcurrent indication
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.