Change in coreboot[master]: mb/intel/jslrvp: Update pad termination for SD related GPIOs
Hello Ronak Kanabar,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/49022
to review the following change.
Change subject: mb/intel/jslrvp: Update pad termination for SD related GPIOs ......................................................................
mb/intel/jslrvp: Update pad termination for SD related GPIOs
Change pad termination for SD related GPIO from NONE to NATIVE. This change aligns SoC gpio to be in line with dedede and also fixes the issue of sporadic detection of SD card.
BUG=None BRANCH=dedede TEST=Check SD card detection works everytime
Change-Id: I0c60cd3edf0ae561846115a0dd3c4fd5b3e26b9c Signed-off-by: Maulik V Vaghela maulik.v.vaghela@intel.com Signed-off-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c 1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/49022/1
diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c index 21e25ab..48ff97b 100644 --- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c +++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c @@ -188,25 +188,25 @@ PAD_CFG_NF(GPP_F18, NONE, DEEP, NF1),
/* SD_SDIO_CMD */ - PAD_CFG_NF(GPP_G0, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G0, NATIVE, DEEP, NF1),
/* SD_SDIO_D0 */ - PAD_CFG_NF(GPP_G1, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G1, NATIVE, DEEP, NF1),
/* SD_SDIO_D1 */ - PAD_CFG_NF(GPP_G2, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G2, NATIVE, DEEP, NF1),
/* SD_SDIO_D2 */ - PAD_CFG_NF(GPP_G3, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G3, NATIVE, DEEP, NF1),
/* SD_SDIO_D3 */ - PAD_CFG_NF(GPP_G4, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G4, NATIVE, DEEP, NF1),
/* SD_SDIO_CD_N */ PAD_CFG_NF(GPP_G5, UP_20K, PWROK, NF1),
/* SD_SDIO_CLK */ - PAD_CFG_NF(GPP_G6, NONE, DEEP, NF1), + PAD_CFG_NF(GPP_G6, NATIVE, DEEP, NF1),
/* SD_SDIO_WP */ PAD_CFG_NF(GPP_G7, DN_20K, PWROK, NF1),
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49022 )
Change subject: mb/intel/jslrvp: Update pad termination for SD related GPIOs ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49022 )
Change subject: mb/intel/jslrvp: Update pad termination for SD related GPIOs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49022/1/src/mainboard/intel/jasperl... File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/49022/1/src/mainboard/intel/jasperl... PS1, Line 206: UP_20K What about this?
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49022?usp=email )
Change subject: mb/intel/jslrvp: Update pad termination for SD related GPIOs ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Furquan Shaikh (Code Review) -
Martin L Roth (Code Review)
-
Maulik V Vaghela (Code Review)
-
Ronak Kanabar (Code Review)