Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Julius Werner, Wonkyu Kim.
Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/83153?usp=email )
Change subject: lib: Add Kconfig variable for fw_config default value
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
Patchset:
PS6:
Please file a bug to have more specific discussion which I'm unable to follow here.
I sense you are trying to boot windows SKU with same binary as Chrome SKU hence, you would like to unify things just for it to be unified.
CBI is specific to chrome design and ideally the same shouldn't exist unless implemented now I would like to ensure FW_CBI config is not at all enabled for all windows SKU. The downside would be, all probe function should fail.
to fix that problem, you need a dedicated devicetree file for booting to Windows SKU. There may be more req from Intel which I'm missing here, hence, please don't rush for the review/merge unless we have good understanding of the requirement.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83153?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9694433e01bdcd9ff1e550585c14ea7ccee020a3
Gerrit-Change-Number: 83153
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sun, 30 Jun 2024 08:23:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes