Joel Kitching has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47233 )
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
vboot: stop implementing VbExDisplayScreen
This function is no longer required to be implemented since EC/AUXFW sync was decoupled from vboot UI. (See CL:2087016.)
BUG=chromium:2117776 TEST=Compile locally BRANCH=none
Signed-off-by: Joel Kitching kitching@google.com Change-Id: I43e8160a4766a38c4fa14bcf4495fc719fbcd6c2 --- M src/security/vboot/ec_sync.c 1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/47233/1
diff --git a/src/security/vboot/ec_sync.c b/src/security/vboot/ec_sync.c index 97b8ed9..1fd7e75 100644 --- a/src/security/vboot/ec_sync.c +++ b/src/security/vboot/ec_sync.c @@ -12,7 +12,6 @@ #include <timer.h> #include <timestamp.h> #include <vb2_api.h> -#include <vboot_api.h> /* for VbExDisplayScreen() and VbScreenData */
#define _EC_FILENAME(select, suffix) \ (select == VB_SELECT_FIRMWARE_READONLY ? "ecro" suffix : "ecrw" suffix) @@ -402,21 +401,6 @@ ***********************************************************************/
/* - * Unsupported. - * - * coreboot does not support the graphics initialization needed to - * display the vboot "wait" screens, etc., because the use case for - * supporting software sync early in the boot flow is to be able to - * quickly update the EC and/or sysjump to RW earlier so that USB-PD - * power (> 15 W) can be negotiated for earlier. - */ -vb2_error_t VbExDisplayScreen(uint32_t screen_type, uint32_t locale, - const VbScreenData *data) -{ - return VB2_ERROR_UNKNOWN; -} - -/* * Write opaque data into NV storage region. */ vb2_error_t vb2ex_commit_data(struct vb2_context *ctx)
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47233 )
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
Patch Set 1:
(1 comment)
Thanks for cleaning this up!
https://review.coreboot.org/c/coreboot/+/47233/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47233/1//COMMIT_MSG@12 PS1, Line 12: 2117776 This is the CL number. Should be 1055125.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47233 )
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47233/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47233/1//COMMIT_MSG@12 PS1, Line 12: 2117776
This is the CL number. Should be 1055125.
Also, this chromium issue has been migrated to b/172343019.
Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47233
to look at the new patch set (#2).
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
vboot: stop implementing VbExDisplayScreen
This function is no longer required to be implemented since EC/AUXFW sync was decoupled from vboot UI. (See CL:2087016.)
BUG=b/172343019 TEST=Compile locally BRANCH=none
Signed-off-by: Joel Kitching kitching@google.com Change-Id: I43e8160a4766a38c4fa14bcf4495fc719fbcd6c2 --- M src/security/vboot/ec_sync.c 1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/47233/2
Hello build bot (Jenkins), Julius Werner, Yu-Ping Wu, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47233
to look at the new patch set (#3).
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
vboot: stop implementing VbExDisplayScreen
This function is no longer required to be implemented since EC/AUXFW sync was decoupled from vboot UI. (See CL:2087016.)
BUG=b:172343019 TEST=Compile locally BRANCH=none
Signed-off-by: Joel Kitching kitching@google.com Change-Id: I43e8160a4766a38c4fa14bcf4495fc719fbcd6c2 --- M src/security/vboot/ec_sync.c 1 file changed, 0 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/47233/3
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47233 )
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47233/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47233/1//COMMIT_MSG@12 PS1, Line 12: 2117776
Also, this chromium issue has been migrated to b/172343019.
Done
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47233 )
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
Patch Set 3: Code-Review+2
Joel Kitching has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47233 )
Change subject: vboot: stop implementing VbExDisplayScreen ......................................................................
vboot: stop implementing VbExDisplayScreen
This function is no longer required to be implemented since EC/AUXFW sync was decoupled from vboot UI. (See CL:2087016.)
BUG=b:172343019 TEST=Compile locally BRANCH=none
Signed-off-by: Joel Kitching kitching@google.com Change-Id: I43e8160a4766a38c4fa14bcf4495fc719fbcd6c2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47233 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Yu-Ping Wu yupingso@google.com --- M src/security/vboot/ec_sync.c 1 file changed, 0 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved
diff --git a/src/security/vboot/ec_sync.c b/src/security/vboot/ec_sync.c index 97b8ed9..1fd7e75 100644 --- a/src/security/vboot/ec_sync.c +++ b/src/security/vboot/ec_sync.c @@ -12,7 +12,6 @@ #include <timer.h> #include <timestamp.h> #include <vb2_api.h> -#include <vboot_api.h> /* for VbExDisplayScreen() and VbScreenData */
#define _EC_FILENAME(select, suffix) \ (select == VB_SELECT_FIRMWARE_READONLY ? "ecro" suffix : "ecrw" suffix) @@ -402,21 +401,6 @@ ***********************************************************************/
/* - * Unsupported. - * - * coreboot does not support the graphics initialization needed to - * display the vboot "wait" screens, etc., because the use case for - * supporting software sync early in the boot flow is to be able to - * quickly update the EC and/or sysjump to RW earlier so that USB-PD - * power (> 15 W) can be negotiated for earlier. - */ -vb2_error_t VbExDisplayScreen(uint32_t screen_type, uint32_t locale, - const VbScreenData *data) -{ - return VB2_ERROR_UNKNOWN; -} - -/* * Write opaque data into NV storage region. */ vb2_error_t vb2ex_commit_data(struct vb2_context *ctx)
-
Joel Kitching (Code Review) -
Yu-Ping Wu (Code Review)