Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/29487 )
Change subject: soc/intel/common: Call EC _PTS/_WAK methods if defined ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 1:
Patch Set 1:
Looks like condrefof only works for the If statement and trying to actually call the method, even if it will not reach that code, causes the ASL compiler to fail.
I guess I will need to guard with a Kconfig option.
Aah yes. Does adding an External help: External (_SB.PCI0.LPCB.EC0.WAK, MethodObj) External (_SB.PCI0.LPCB.EC0.PTS, MethodObj)
Yeah this works, but I was concerned it would have issues at the OS level if these methods didn't actually exist. I did some testing and it seems to be ok.
Of course I tested the case that was failing before and did not actually re-compile for the sarien/arcada boards. It seems a kconfig option is the only safe path forward here.