Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40955 )
Change subject: payloads/external/GRUB2: prevent rebuild without actual changes
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40955/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40955/4//COMMIT_MSG@10
PS4, Line 10: caused by Make detecting a change in the dependency on the config file.
Only the revision affects GRUB directly. There is no other cb config option having an influence. […]
tbh there is one second (the extra module) but it's passed directly to make so handled in any case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf5a316d0c9761426ec2ee306d78cd56d4bf19b5
Gerrit-Change-Number: 40955
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Denis Carikli
GNUtoo@no-log.org
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 May 2020 22:55:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment