Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25437 )
Change subject: FSP 2.0: Add fsp_relax_security
......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n...
File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n...
PS18, Line 70: __attribute__((weak)) bool fsp_relax_security(void)
Well the purpose was to set it at runtime, not compile time ;)
Huh? Tbh I'm not sure how that would be used, anyway. However, I wonder if we want to always add debug/testing functionality, even in production images. "Relax security" doesn't sound like something that should be always there.
When using CHIPSET_LOCKDOWN_COREBOOT, wouldn't that be the same (setting it at build time)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25437
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I972e7387c2612ee0053df21afb55b0b264961174
Gerrit-Change-Number: 25437
Gerrit-PatchSet: 20
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
d.guckian20@gmail.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Wed, 11 Nov 2020 17:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment