Nico Huber has posted comments on this change. ( https://review.coreboot.org/29388 )
Change subject: sb/intel/lynxpoint: Deduplicate `acpi_fill_madt()` ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/29388/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29388/1//COMMIT_MSG@11 PS1, Line 11: copied from sb/intel/bd82x6x Maybe sb/intel/common/ is a better place for the things you copied from bd82x6x? Many things actually didn't change from ICH7 to PCH9 (Wildcat Point), so this might apply to many more systems.
https://review.coreboot.org/#/c/29388/1/src/southbridge/intel/lynxpoint/madt... File src/southbridge/intel/lynxpoint/madt.c:
https://review.coreboot.org/#/c/29388/1/src/southbridge/intel/lynxpoint/madt... PS1, Line 16: #include <types.h> : #include <string.h> : #include <cbmem.h> : #include <console/console.h> : #include <arch/acpi.h> : #include <arch/ioapic.h> : #include <arch/acpigen.h> : #include <arch/smp/mpspec.h> That can't be all needed.
-
Nico Huber (Code Review)