Change in coreboot[master]: [RFC] device: Introduce new method for setting device states
Attention is currently required from: Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Michael Niewöhner, Patrick Rudolph, Felix Held. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )
Change subject: [RFC] device: Introduce new method for setting device states ......................................................................
Patch Set 16:
(6 comments)
File src/include/device/devenmap.h:
https://review.coreboot.org/c/coreboot/+/52493/comment/38fac214_ebdf5def PS14, Line 12: const
not sure if that's right. […]
that's correct, see https://review.coreboot.org/c/coreboot/+/52493/comment/1fedd8bc_03ecc956/
https://review.coreboot.org/c/coreboot/+/52493/comment/fa6ebfc2_a7e4ce6a PS14, Line 12: uint8_t
probably const
that's a pointer, shouldn't be const.
https://review.coreboot.org/c/coreboot/+/52493/comment/ff5cbb64_80049a65 PS14, Line 17: const
drop here; keep in function definition; see comment here https://review.coreboot. […]
Done
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/52493/comment/3283d54c_ccef03e7 PS13, Line 461: if (!xdci_can_enable()) : params->XdciEnable = 0;
params->XdciEnable = xdci_can_enable();
Done
File src/soc/intel/skylake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/52493/comment/3db3f0d0_6495b4d7 PS13, Line 137: PCH_DEVFN_SMBUS }, : { &m_cfg->EnableTraceHub, PCH
alignment
Done
https://review.coreboot.org/c/coreboot/+/52493/comment/ce41643c_a7a59b72 PS13, Line 138:
tab
Done
-
Felix Singer (Code Review)