Change in coreboot[master]: Added multiboot support to cbfstool and made changes to behaviour for...
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27957 )
Change subject: Added multiboot support to cbfstool and made changes to behaviour for cbfs add-payload ......................................................................
Patch Set 1:
(10 comments)
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-mkpayload.c File util/cbfstool/cbfs-mkpayload.c:
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-mkpayload.c@551 PS1, Line 551: " 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-mkpayload.c@551 PS1, Line 551: " 0x%x entry: 0x%x\n",mboot_hdr.load_addr,mboot_hdr.entry_addr); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c File util/cbfstool/cbfs-payload-linux.c:
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 246: if ( hdr->boot_sector_magic != 0xAA55 ) { space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 246: if ( hdr->boot_sector_magic != 0xAA55 ) { space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 250: if ( (hdr->header_magic[0] != 'H')|| spaces required around that '||' (ctx:VxE)
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 250: if ( (hdr->header_magic[0] != 'H')|| space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 251: (hdr->header_magic[1] != 'd')|| spaces required around that '||' (ctx:VxE)
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 252: (hdr->header_magic[2] != 'r')|| spaces required around that '||' (ctx:VxE)
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfs-payload-linux.c@2... PS1, Line 253: (hdr->header_magic[3] != 'S')){ space required before the open brace '{'
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/#/c/27957/1/util/cbfstool/cbfstool.c@767 PS1, Line 767: ERROR("Not a supported payload type (ELF / FV / bzImage / Multiboot).\n"); line over 80 characters
-
build bot (Jenkins) (Code Review)