Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29577 )
Change subject: mb/emulation/qemu-i440fx|q35: Get rid of unused headers
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx/...
File src/mainboard/emulation/qemu-i440fx/mainboard.c:
https://review.coreboot.org/#/c/29577/1/src/mainboard/emulation/qemu-i440fx/...
PS1, Line 21:
ah, true that
I'd like to have a single header for those functions, but it requires touching 50% of coreboot's x86 code...
--
To view, visit
https://review.coreboot.org/29577
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf0e4ef5b090d15ad823747fcf9219644e130fc
Gerrit-Change-Number: 29577
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 11 Nov 2018 18:30:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No