Attention is currently required from: Martin Roth, Marshall Dawson, Arthur Heymans, Kyösti Mälkki, Yu-Ping Wu, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56122 )
Change subject: Makefile.inc: Add x86 bootblock as a separate target
......................................................................
Patch Set 14:
(3 comments)
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56122/comment/e2bc5e60_e7692a80
PS9, Line 107: bootblock-options := $(TS_OPTIONS) $(TXTIBB)
Can't we just put the -b here as well (maybe if you use = instead of := )? Or is there no way to m […]
Thanks, I think that's cleaner.
File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/56122/comment/397feb9a_03cf900a
PS11, Line 103: ifneq ($(CONFIG_UPDATE_IMAGE),y)
Shouldn't this also depend on TOP_ALIGNED_BOOTBLOCK? (And in that case maybe go in the arch-independent Makefile?)
https://review.coreboot.org/c/coreboot/+/56122/comment/4aebb9b0_7cc5edc9
PS11, Line 106: -$(CBFSTOOL) $< remove -n bootblock 2>/dev/null
Why are we removing something first?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56122
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4de9d7fedf1ae5a37a3310dd42eb07b44c030930
Gerrit-Change-Number: 56122
Gerrit-PatchSet: 14
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Apr 2022 20:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment