Attention is currently required from: Subrata Banik, Paul Menzel, Angel Pons, Arthur Heymans.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62699 )
Change subject: lib/spd: Do not print part number if it is not available
......................................................................
Patch Set 1:
(1 comment)
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/62699/comment/6cfa7f67_5d62f0af
PS1, Line 173: }
Print some placeholder as the part number? UNKNOWN or so?
I would rather like to skip this line if there is no part number as there is no additional information that can be gained from an "UNKNOWN".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62699
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If7224c6e114731b1c03915a2bde80f57369d0cee
Gerrit-Change-Number: 62699
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 11 Mar 2022 07:52:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment