Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25344 )
Change subject: ACPI: Add SPCR table
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
https://review.coreboot.org/#/c/25344/3/src/arch/x86/acpi.c
File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/25344/3/src/arch/x86/acpi.c@1328
PS3, Line 1328: Error
From the subsequent commit this does seem to be called every time, so I suspect you want to make thi […]
Ultimately we want it to supply the correct serial port even if console is disabled. For now, I'm adding a check that will exit the routine if the coreboot serial console is disabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ff31da061c88a6f3e3cf76285f8ab78ee35509c
Gerrit-Change-Number: 25344
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-Comment-Date: Tue, 11 Jun 2019 17:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Gerrit-MessageType: comment