Attention is currently required from: Felix Singer, Michał Żygowski, Tim Wawrzynczak, Michał Kopeć, Angel Pons, Arthur Heymans.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68791 )
Change subject: ec/clevo/it5570e: add driver for EC used on various Clevo laptops ......................................................................
Patch Set 8:
(1 comment)
File src/ec/clevo/it5570e/ssdt.c:
https://review.coreboot.org/c/coreboot/+/68791/comment/7959a79a_352acf48 PS4, Line 66: acpigen_emit_ext_op(FIELD_OP); : acpigen_write_len_f(); : acpigen_emit_simple_namestring(opreg.name); : acpigen_emit_byte(flags); : : for (int fan = 1; fan <= fan_cnt; fan++) { : /* temps */ : for (int i = 1; i <= IT5570E_FAN_CURVE_LEN; i++) { : snprintf(fieldname, 5, "F%dT%d", fan, i); : acpigen_write_field_name(fieldname, 8); : } : : /* duties */ : for (int i = 1; i <= IT5570E_FAN_CURVE_LEN; i++) { : snprintf(fieldname, 5, "F%dD%d", fan, i); : acpigen_write_field_name(fieldname, 8); : } : : /* ramps */ : for (int i = 1; i < IT5570E_FAN_CURVE_LEN; i++) { : snprintf(fieldname, 5, "F%dR%d", fan, i); : acpigen_write_field_name(fieldname, 16); : } : } : : acpigen_pop_len();
Sounds like a good idea. However, I'd like to postpone that to a different change. […]
Done