Attention is currently required from: Martin Roth, Arthur Heymans, Patrick Rudolph. Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/55009
to review the following change.
Change subject: Makefile: Remove the -mno-mmx flag ......................................................................
Makefile: Remove the -mno-mmx flag
Tested with BUILD_TIMELESS: this does not change the binaries.
Change-Id: I0d22aea7be3ff521fd289504bb131c32a19fab4b Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M Makefile M src/cpu/Kconfig M src/cpu/intel/haswell/Kconfig M src/cpu/intel/model_206ax/Kconfig M src/cpu/intel/socket_441/Kconfig M src/cpu/intel/socket_BGA956/Kconfig M src/cpu/intel/socket_FCBGA559/Kconfig M src/cpu/intel/socket_LGA775/Kconfig M src/cpu/intel/socket_m/Kconfig M src/cpu/intel/socket_mPGA604/Kconfig M src/cpu/intel/socket_p/Kconfig 11 files changed, 0 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/55009/1
diff --git a/Makefile b/Makefile index ea196c9..0210b2d 100644 --- a/Makefile +++ b/Makefile @@ -175,10 +175,6 @@ Restarting the build should fix that, or explain the problem) endif
-ifneq ($(CONFIG_MMX),y) -CFLAGS_x86_32 += -mno-mmx -endif - ifneq ($(UNIT_TEST),1) include toolchain.inc endif diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig index 297b1a1..7d315a4 100644 --- a/src/cpu/Kconfig +++ b/src/cpu/Kconfig @@ -27,12 +27,6 @@ This option is used to enable certain functions to make coreboot work correctly on symmetric multi processor (SMP) systems.
-config MMX - bool - help - Select MMX in your socket or model Kconfig if your CPU has MMX - streaming SIMD instructions. - config SSE bool help diff --git a/src/cpu/intel/haswell/Kconfig b/src/cpu/intel/haswell/Kconfig index 0d3d132..30571df 100644 --- a/src/cpu/intel/haswell/Kconfig +++ b/src/cpu/intel/haswell/Kconfig @@ -8,7 +8,6 @@ def_bool y select ARCH_ALL_STAGES_X86_32 select BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES - select MMX select SSE2 select UDELAY_TSC select TSC_MONOTONIC_TIMER diff --git a/src/cpu/intel/model_206ax/Kconfig b/src/cpu/intel/model_206ax/Kconfig index 5098ac7..bb20e8b 100644 --- a/src/cpu/intel/model_206ax/Kconfig +++ b/src/cpu/intel/model_206ax/Kconfig @@ -7,7 +7,6 @@ def_bool y select ARCH_ALL_STAGES_X86_32 select BOOT_DEVICE_SPI_FLASH_NO_EARLY_WRITES - select MMX select SSE2 select UDELAY_TSC select TSC_MONOTONIC_TIMER diff --git a/src/cpu/intel/socket_441/Kconfig b/src/cpu/intel/socket_441/Kconfig index 5b6ae7f..53902936 100644 --- a/src/cpu/intel/socket_441/Kconfig +++ b/src/cpu/intel/socket_441/Kconfig @@ -6,7 +6,6 @@ config SOCKET_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_MODEL_106CX - select MMX select SSE select SETUP_XIP_CACHE
diff --git a/src/cpu/intel/socket_BGA956/Kconfig b/src/cpu/intel/socket_BGA956/Kconfig index 638653c..d8bc7a4 100644 --- a/src/cpu/intel/socket_BGA956/Kconfig +++ b/src/cpu/intel/socket_BGA956/Kconfig @@ -1,7 +1,6 @@ config CPU_INTEL_SOCKET_BGA956 bool select CPU_INTEL_MODEL_1067X - select MMX select SSE
if CPU_INTEL_SOCKET_BGA956 diff --git a/src/cpu/intel/socket_FCBGA559/Kconfig b/src/cpu/intel/socket_FCBGA559/Kconfig index 5105f09..b508d03 100644 --- a/src/cpu/intel/socket_FCBGA559/Kconfig +++ b/src/cpu/intel/socket_FCBGA559/Kconfig @@ -8,7 +8,6 @@ config SOCKET_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_MODEL_106CX - select MMX select SSE select CPU_HAS_L2_ENABLE_MSR
diff --git a/src/cpu/intel/socket_LGA775/Kconfig b/src/cpu/intel/socket_LGA775/Kconfig index 0848d26..272e4ba 100644 --- a/src/cpu/intel/socket_LGA775/Kconfig +++ b/src/cpu/intel/socket_LGA775/Kconfig @@ -11,7 +11,6 @@ # select CPU_INTEL_MODEL_F6X # select CPU_INTEL_MODEL_1066X select CPU_INTEL_MODEL_1067X - select MMX select SSE select SIPI_VECTOR_IN_ROM
diff --git a/src/cpu/intel/socket_m/Kconfig b/src/cpu/intel/socket_m/Kconfig index 50eb7e3..9c0a9e5 100644 --- a/src/cpu/intel/socket_m/Kconfig +++ b/src/cpu/intel/socket_m/Kconfig @@ -7,7 +7,6 @@ def_bool y select CPU_INTEL_MODEL_6EX select CPU_INTEL_MODEL_6FX - select MMX select SSE
config DCACHE_RAM_BASE diff --git a/src/cpu/intel/socket_mPGA604/Kconfig b/src/cpu/intel/socket_mPGA604/Kconfig index 7b08699..238e373 100644 --- a/src/cpu/intel/socket_mPGA604/Kconfig +++ b/src/cpu/intel/socket_mPGA604/Kconfig @@ -6,7 +6,6 @@ config SOCKET_SPECIFIC_OPTIONS def_bool y select CPU_INTEL_MODEL_F2X - select MMX select SSE select UDELAY_TSC select TSC_MONOTONIC_TIMER diff --git a/src/cpu/intel/socket_p/Kconfig b/src/cpu/intel/socket_p/Kconfig index a7c8ab1..e4220e5 100644 --- a/src/cpu/intel/socket_p/Kconfig +++ b/src/cpu/intel/socket_p/Kconfig @@ -2,7 +2,6 @@ bool select CPU_INTEL_MODEL_1067X select CPU_INTEL_MODEL_6FX - select MMX select SSE
if CPU_INTEL_SOCKET_P
-
Arthur Heymans (Code Review)