[M] Change in coreboot[master]: soc/amd/common/xhci: Add support for logging XHCI wake events - coreboot-gerrit

3 Oct 2022


      Attention is currently required from: Robert Zieba, Jason Glenesk, Matt DeVillier, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67936 )
Change subject: soc/amd/common/xhci: Add support for logging XHCI wake events
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/block/xhci/elog.c:
https://review.coreboot.org/c/coreboot/+/67936/comment/a16cb80a_ba7d365e 
PS1, Line 17: read32
`read32p`
https://review.coreboot.org/c/coreboot/+/67936/comment/d617bfa5_dd48be4e 
PS1, Line 64: info[i].usb_info
Can you decalre a local to make this easier to read
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/67936
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0489e1df55c4e63cb8a306099e3f31c82eebd58
Gerrit-Change-Number: 67936
Gerrit-PatchSet: 1
Gerrit-Owner: Robert Zieba robertzieba@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Robert Zieba robertzieba@google.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 03 Oct 2022 15:56:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment