Change in coreboot[master]: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
Define DSDT revision and use it.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl 161 files changed, 161 insertions(+), 160 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/1
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 53308f3..d190344 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -41,6 +41,7 @@
#define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */ +#define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
#if !defined(__ASSEMBLER__) && !defined(__ACPI__) #include <commonlib/helpers.h> diff --git a/src/mainboard/amd/gardenia/dsdt.asl b/src/mainboard/amd/gardenia/dsdt.asl index a2de635..d704581 100644 --- a/src/mainboard/amd/gardenia/dsdt.asl +++ b/src/mainboard/amd/gardenia/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/inagua/dsdt.asl b/src/mainboard/amd/inagua/dsdt.asl index a395d24..7407a8d 100644 --- a/src/mainboard/amd/inagua/dsdt.asl +++ b/src/mainboard/amd/inagua/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/mandolin/dsdt.asl b/src/mainboard/amd/mandolin/dsdt.asl index 06612a8..612fa32 100644 --- a/src/mainboard/amd/mandolin/dsdt.asl +++ b/src/mainboard/amd/mandolin/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/olivehill/dsdt.asl b/src/mainboard/amd/olivehill/dsdt.asl index 24b54c9..b6760ff 100644 --- a/src/mainboard/amd/olivehill/dsdt.asl +++ b/src/mainboard/amd/olivehill/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/padmelon/dsdt.asl b/src/mainboard/amd/padmelon/dsdt.asl index 716c791..2e78381 100644 --- a/src/mainboard/amd/padmelon/dsdt.asl +++ b/src/mainboard/amd/padmelon/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/parmer/dsdt.asl b/src/mainboard/amd/parmer/dsdt.asl index b04567a..4834366 100644 --- a/src/mainboard/amd/parmer/dsdt.asl +++ b/src/mainboard/amd/parmer/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/persimmon/dsdt.asl b/src/mainboard/amd/persimmon/dsdt.asl index a395d24..7407a8d 100644 --- a/src/mainboard/amd/persimmon/dsdt.asl +++ b/src/mainboard/amd/persimmon/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/south_station/dsdt.asl b/src/mainboard/amd/south_station/dsdt.asl index a395d24..7407a8d 100644 --- a/src/mainboard/amd/south_station/dsdt.asl +++ b/src/mainboard/amd/south_station/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/thatcher/dsdt.asl b/src/mainboard/amd/thatcher/dsdt.asl index b04567a..4834366 100644 --- a/src/mainboard/amd/thatcher/dsdt.asl +++ b/src/mainboard/amd/thatcher/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/amd/union_station/dsdt.asl b/src/mainboard/amd/union_station/dsdt.asl index a395d24..7407a8d 100644 --- a/src/mainboard/amd/union_station/dsdt.asl +++ b/src/mainboard/amd/union_station/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/aopen/dxplplusu/dsdt.asl b/src/mainboard/aopen/dxplplusu/dsdt.asl index 613de6f..68d514e 100644 --- a/src/mainboard/aopen/dxplplusu/dsdt.asl +++ b/src/mainboard/aopen/dxplplusu/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20111103 // OEM revision diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl index 9b5ba55..48a7ed19 100644 --- a/src/mainboard/apple/macbook21/dsdt.asl +++ b/src/mainboard/apple/macbook21/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/apple/macbookair4_2/dsdt.asl b/src/mainboard/apple/macbookair4_2/dsdt.asl index e68c018..8ac442d 100644 --- a/src/mainboard/apple/macbookair4_2/dsdt.asl +++ b/src/mainboard/apple/macbookair4_2/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/asrock/b75pro3-m/dsdt.asl b/src/mainboard/asrock/b75pro3-m/dsdt.asl index 20cca3e..5941193 100644 --- a/src/mainboard/asrock/b75pro3-m/dsdt.asl +++ b/src/mainboard/asrock/b75pro3-m/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/asrock/b85m_pro4/dsdt.asl b/src/mainboard/asrock/b85m_pro4/dsdt.asl index bbc9630..8228886 100644 --- a/src/mainboard/asrock/b85m_pro4/dsdt.asl +++ b/src/mainboard/asrock/b85m_pro4/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 /* OEM revision */ diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl index d1896ad..b97bd80 100644 --- a/src/mainboard/asrock/e350m1/dsdt.asl +++ b/src/mainboard/asrock/e350m1/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/asrock/g41c-gs/dsdt.asl b/src/mainboard/asrock/g41c-gs/dsdt.asl index fe69e95..c0f72bf 100644 --- a/src/mainboard/asrock/g41c-gs/dsdt.asl +++ b/src/mainboard/asrock/g41c-gs/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/asrock/h110m/dsdt.asl b/src/mainboard/asrock/h110m/dsdt.asl index 4059596..741a234 100644 --- a/src/mainboard/asrock/h110m/dsdt.asl +++ b/src/mainboard/asrock/h110m/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/asrock/h81m-hds/dsdt.asl b/src/mainboard/asrock/h81m-hds/dsdt.asl index 8fec596..5e0ab8b 100644 --- a/src/mainboard/asrock/h81m-hds/dsdt.asl +++ b/src/mainboard/asrock/h81m-hds/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT Revision: ACPI v3.0 */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20181031 /* OEM Revision */ diff --git a/src/mainboard/asrock/imb-a180/dsdt.asl b/src/mainboard/asrock/imb-a180/dsdt.asl index 24b54c9..b6760ff 100644 --- a/src/mainboard/asrock/imb-a180/dsdt.asl +++ b/src/mainboard/asrock/imb-a180/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/asus/a88xm-e/dsdt.asl b/src/mainboard/asus/a88xm-e/dsdt.asl index aac9c84..d143cde 100644 --- a/src/mainboard/asus/a88xm-e/dsdt.asl +++ b/src/mainboard/asus/a88xm-e/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/asus/am1i-a/dsdt.asl b/src/mainboard/asus/am1i-a/dsdt.asl index 13e97dc..e916041 100644 --- a/src/mainboard/asus/am1i-a/dsdt.asl +++ b/src/mainboard/asus/am1i-a/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/asus/f2a85-m/dsdt.asl b/src/mainboard/asus/f2a85-m/dsdt.asl index 634a928..d442a86 100644 --- a/src/mainboard/asus/f2a85-m/dsdt.asl +++ b/src/mainboard/asus/f2a85-m/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/asus/h61m-cs/dsdt.asl b/src/mainboard/asus/h61m-cs/dsdt.asl index ded71a1..d22ea9e 100644 --- a/src/mainboard/asus/h61m-cs/dsdt.asl +++ b/src/mainboard/asus/h61m-cs/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI 2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/asus/maximus_iv_gene-z/dsdt.asl b/src/mainboard/asus/maximus_iv_gene-z/dsdt.asl index 60d6dc5..bea2f05 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/dsdt.asl +++ b/src/mainboard/asus/maximus_iv_gene-z/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT Revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20171231 /* OEM Revision */ diff --git a/src/mainboard/asus/p5gc-mx/dsdt.asl b/src/mainboard/asus/p5gc-mx/dsdt.asl index 0a9ab0f..bb57b17 100644 --- a/src/mainboard/asus/p5gc-mx/dsdt.asl +++ b/src/mainboard/asus/p5gc-mx/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/asus/p5qc/dsdt.asl b/src/mainboard/asus/p5qc/dsdt.asl index cd885c8..584099c 100644 --- a/src/mainboard/asus/p5qc/dsdt.asl +++ b/src/mainboard/asus/p5qc/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00000001 // OEM revision diff --git a/src/mainboard/asus/p5ql-em/dsdt.asl b/src/mainboard/asus/p5ql-em/dsdt.asl index 2981dc6..920765f 100644 --- a/src/mainboard/asus/p5ql-em/dsdt.asl +++ b/src/mainboard/asus/p5ql-em/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00000001 // OEM revision diff --git a/src/mainboard/asus/p5qpl-am/dsdt.asl b/src/mainboard/asus/p5qpl-am/dsdt.asl index fe69e95..c0f72bf 100644 --- a/src/mainboard/asus/p5qpl-am/dsdt.asl +++ b/src/mainboard/asus/p5qpl-am/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/asus/p8h61-m_lx/dsdt.asl b/src/mainboard/asus/p8h61-m_lx/dsdt.asl index 60d6dc5..bea2f05 100644 --- a/src/mainboard/asus/p8h61-m_lx/dsdt.asl +++ b/src/mainboard/asus/p8h61-m_lx/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT Revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20171231 /* OEM Revision */ diff --git a/src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl b/src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl index fba6cc7..3ada1b3 100644 --- a/src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl +++ b/src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI 2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 /* OEM revision */ diff --git a/src/mainboard/asus/p8h61-m_pro/dsdt.asl b/src/mainboard/asus/p8h61-m_pro/dsdt.asl index 01d1fe6..8a4e405 100644 --- a/src/mainboard/asus/p8h61-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8h61-m_pro/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl index a5ab91d..22e66d0 100644 --- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl +++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI 2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 /* OEM revision */ diff --git a/src/mainboard/asus/p8z77-v_lx2/dsdt.asl b/src/mainboard/asus/p8z77-v_lx2/dsdt.asl index 6fa3b55..1028b69 100644 --- a/src/mainboard/asus/p8z77-v_lx2/dsdt.asl +++ b/src/mainboard/asus/p8z77-v_lx2/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 /* OEM revision */ diff --git a/src/mainboard/bap/ode_e20XX/dsdt.asl b/src/mainboard/bap/ode_e20XX/dsdt.asl index 24b54c9..b6760ff 100644 --- a/src/mainboard/bap/ode_e20XX/dsdt.asl +++ b/src/mainboard/bap/ode_e20XX/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/biostar/a68n_5200/dsdt.asl b/src/mainboard/biostar/a68n_5200/dsdt.asl index 24b54c9..b6760ff 100644 --- a/src/mainboard/biostar/a68n_5200/dsdt.asl +++ b/src/mainboard/biostar/a68n_5200/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/biostar/am1ml/dsdt.asl b/src/mainboard/biostar/am1ml/dsdt.asl index 01502b2..813ed2e 100644 --- a/src/mainboard/biostar/am1ml/dsdt.asl +++ b/src/mainboard/biostar/am1ml/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/biostar/th61-itx/dsdt.asl b/src/mainboard/biostar/th61-itx/dsdt.asl index 18908d3..e2cc2b2 100644 --- a/src/mainboard/biostar/th61-itx/dsdt.asl +++ b/src/mainboard/biostar/th61-itx/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/bostentech/gbyt4/dsdt.asl b/src/mainboard/bostentech/gbyt4/dsdt.asl index 56e01c4..ebc034b 100644 --- a/src/mainboard/bostentech/gbyt4/dsdt.asl +++ b/src/mainboard/bostentech/gbyt4/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/clevo/cml-u/dsdt.asl b/src/mainboard/clevo/cml-u/dsdt.asl index eac27b5..a611463 100644 --- a/src/mainboard/clevo/cml-u/dsdt.asl +++ b/src/mainboard/clevo/cml-u/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/compulab/intense_pc/dsdt.asl b/src/mainboard/compulab/intense_pc/dsdt.asl index 737f02f..110c3ba 100644 --- a/src/mainboard/compulab/intense_pc/dsdt.asl +++ b/src/mainboard/compulab/intense_pc/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/dell/optiplex_9010/dsdt.asl b/src/mainboard/dell/optiplex_9010/dsdt.asl index 6a6dcb4..89ea9e5 100644 --- a/src/mainboard/dell/optiplex_9010/dsdt.asl +++ b/src/mainboard/dell/optiplex_9010/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI 2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 /* OEM revision */ diff --git a/src/mainboard/elmex/pcm205400/dsdt.asl b/src/mainboard/elmex/pcm205400/dsdt.asl index a395d24..7407a8d 100644 --- a/src/mainboard/elmex/pcm205400/dsdt.asl +++ b/src/mainboard/elmex/pcm205400/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/facebook/fbg1701/dsdt.asl b/src/mainboard/facebook/fbg1701/dsdt.asl index b8270bc..a4d50a9 100644 --- a/src/mainboard/facebook/fbg1701/dsdt.asl +++ b/src/mainboard/facebook/fbg1701/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/facebook/monolith/dsdt.asl b/src/mainboard/facebook/monolith/dsdt.asl index 238e87b..063e64a 100644 --- a/src/mainboard/facebook/monolith/dsdt.asl +++ b/src/mainboard/facebook/monolith/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/foxconn/d41s/dsdt.asl b/src/mainboard/foxconn/d41s/dsdt.asl index 6e4ecfc..d00a59a 100644 --- a/src/mainboard/foxconn/d41s/dsdt.asl +++ b/src/mainboard/foxconn/d41s/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/foxconn/g41s-k/dsdt.asl b/src/mainboard/foxconn/g41s-k/dsdt.asl index fe69e95..c0f72bf 100644 --- a/src/mainboard/foxconn/g41s-k/dsdt.asl +++ b/src/mainboard/foxconn/g41s-k/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/getac/p470/dsdt.asl b/src/mainboard/getac/p470/dsdt.asl index 3fdc158..2c42bd0 100644 --- a/src/mainboard/getac/p470/dsdt.asl +++ b/src/mainboard/getac/p470/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl index 94684d0..05f1f1a 100644 --- a/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl +++ b/src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl b/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl index 2fd748f..3f190b8 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl +++ b/src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl b/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl index fe69e95..c0f72bf 100644 --- a/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl +++ b/src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl b/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl index f9d158e..823ce15 100644 --- a/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl +++ b/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/gizmosphere/gizmo/dsdt.asl b/src/mainboard/gizmosphere/gizmo/dsdt.asl index ef08555..9f8a574 100644 --- a/src/mainboard/gizmosphere/gizmo/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/gizmosphere/gizmo2/dsdt.asl b/src/mainboard/gizmosphere/gizmo2/dsdt.asl index 24b54c9..b6760ff 100644 --- a/src/mainboard/gizmosphere/gizmo2/dsdt.asl +++ b/src/mainboard/gizmosphere/gizmo2/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/google/auron/dsdt.asl b/src/mainboard/google/auron/dsdt.asl index c0f4d9f..fb42de5 100644 --- a/src/mainboard/google/auron/dsdt.asl +++ b/src/mainboard/google/auron/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/beltino/dsdt.asl b/src/mainboard/google/beltino/dsdt.asl index e262af9..61c5797 100644 --- a/src/mainboard/google/beltino/dsdt.asl +++ b/src/mainboard/google/beltino/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/butterfly/dsdt.asl b/src/mainboard/google/butterfly/dsdt.asl index 23f4370..9f5713d 100644 --- a/src/mainboard/google/butterfly/dsdt.asl +++ b/src/mainboard/google/butterfly/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/cyan/dsdt.asl b/src/mainboard/google/cyan/dsdt.asl index beb355a..70bed76 100644 --- a/src/mainboard/google/cyan/dsdt.asl +++ b/src/mainboard/google/cyan/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/google/dedede/dsdt.asl b/src/mainboard/google/dedede/dsdt.asl index 6365e5e..d044d2f 100644 --- a/src/mainboard/google/dedede/dsdt.asl +++ b/src/mainboard/google/dedede/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/google/deltaur/dsdt.asl b/src/mainboard/google/deltaur/dsdt.asl index fac58bd..85c5250 100644 --- a/src/mainboard/google/deltaur/dsdt.asl +++ b/src/mainboard/google/deltaur/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/google/drallion/dsdt.asl b/src/mainboard/google/drallion/dsdt.asl index c9f7391..a0202b6 100644 --- a/src/mainboard/google/drallion/dsdt.asl +++ b/src/mainboard/google/drallion/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/google/eve/dsdt.asl b/src/mainboard/google/eve/dsdt.asl index b73dcb5..db8614e 100644 --- a/src/mainboard/google/eve/dsdt.asl +++ b/src/mainboard/google/eve/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/fizz/dsdt.asl b/src/mainboard/google/fizz/dsdt.asl index 83c7718..af23f17 100644 --- a/src/mainboard/google/fizz/dsdt.asl +++ b/src/mainboard/google/fizz/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/glados/dsdt.asl b/src/mainboard/google/glados/dsdt.asl index 040c960..f3ff50e 100644 --- a/src/mainboard/google/glados/dsdt.asl +++ b/src/mainboard/google/glados/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/hatch/dsdt.asl b/src/mainboard/google/hatch/dsdt.asl index d60da37..f2b944f 100644 --- a/src/mainboard/google/hatch/dsdt.asl +++ b/src/mainboard/google/hatch/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/google/jecht/dsdt.asl b/src/mainboard/google/jecht/dsdt.asl index 7770198..df20f90 100644 --- a/src/mainboard/google/jecht/dsdt.asl +++ b/src/mainboard/google/jecht/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl index ebee0f7..e2ddee9 100644 --- a/src/mainboard/google/kahlee/dsdt.asl +++ b/src/mainboard/google/kahlee/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/google/link/dsdt.asl b/src/mainboard/google/link/dsdt.asl index 23f4370..9f5713d 100644 --- a/src/mainboard/google/link/dsdt.asl +++ b/src/mainboard/google/link/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/octopus/dsdt.asl b/src/mainboard/google/octopus/dsdt.asl index 315cf7c..15d1db3 100644 --- a/src/mainboard/google/octopus/dsdt.asl +++ b/src/mainboard/google/octopus/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/parrot/dsdt.asl b/src/mainboard/google/parrot/dsdt.asl index 3164c81..8a220bb 100644 --- a/src/mainboard/google/parrot/dsdt.asl +++ b/src/mainboard/google/parrot/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/poppy/dsdt.asl b/src/mainboard/google/poppy/dsdt.asl index 29dbb58..614a4b0 100644 --- a/src/mainboard/google/poppy/dsdt.asl +++ b/src/mainboard/google/poppy/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/rambi/dsdt.asl b/src/mainboard/google/rambi/dsdt.asl index a54a646f..807f3ff 100644 --- a/src/mainboard/google/rambi/dsdt.asl +++ b/src/mainboard/google/rambi/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/reef/dsdt.asl b/src/mainboard/google/reef/dsdt.asl index 315cf7c..15d1db3 100644 --- a/src/mainboard/google/reef/dsdt.asl +++ b/src/mainboard/google/reef/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/sarien/dsdt.asl b/src/mainboard/google/sarien/dsdt.asl index 0382fcb..5997d73 100644 --- a/src/mainboard/google/sarien/dsdt.asl +++ b/src/mainboard/google/sarien/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/google/slippy/dsdt.asl b/src/mainboard/google/slippy/dsdt.asl index 805363f..a2a3451 100644 --- a/src/mainboard/google/slippy/dsdt.asl +++ b/src/mainboard/google/slippy/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/stout/dsdt.asl b/src/mainboard/google/stout/dsdt.asl index 96bbb9c..f6aa5ef 100644 --- a/src/mainboard/google/stout/dsdt.asl +++ b/src/mainboard/google/stout/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl index d0bab1a..fa87fe5 100644 --- a/src/mainboard/google/volteer/dsdt.asl +++ b/src/mainboard/google/volteer/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/google/zork/dsdt.asl b/src/mainboard/google/zork/dsdt.asl index 08ea5cf..595aa1b 100644 --- a/src/mainboard/google/zork/dsdt.asl +++ b/src/mainboard/google/zork/dsdt.asl @@ -8,7 +8,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/hp/abm/dsdt.asl b/src/mainboard/hp/abm/dsdt.asl index 24b54c9..b6760ff 100644 --- a/src/mainboard/hp/abm/dsdt.asl +++ b/src/mainboard/hp/abm/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl index 737f02f..110c3ba 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl +++ b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl index 4cd6a31..55ba0ea 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/hp/snb_ivb_laptops/dsdt.asl b/src/mainboard/hp/snb_ivb_laptops/dsdt.asl index 737f02f..110c3ba 100644 --- a/src/mainboard/hp/snb_ivb_laptops/dsdt.asl +++ b/src/mainboard/hp/snb_ivb_laptops/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/hp/z220_sff_workstation/dsdt.asl b/src/mainboard/hp/z220_sff_workstation/dsdt.asl index 737f02f..110c3ba 100644 --- a/src/mainboard/hp/z220_sff_workstation/dsdt.asl +++ b/src/mainboard/hp/z220_sff_workstation/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/ibase/mb899/dsdt.asl b/src/mainboard/ibase/mb899/dsdt.asl index 98113bf..0c3b45f 100644 --- a/src/mainboard/ibase/mb899/dsdt.asl +++ b/src/mainboard/ibase/mb899/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/intel/apollolake_rvp/dsdt.asl b/src/mainboard/intel/apollolake_rvp/dsdt.asl index 3285262..3a051a0 100644 --- a/src/mainboard/intel/apollolake_rvp/dsdt.asl +++ b/src/mainboard/intel/apollolake_rvp/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/intel/baskingridge/dsdt.asl b/src/mainboard/intel/baskingridge/dsdt.asl index 388d109..2458c87 100644 --- a/src/mainboard/intel/baskingridge/dsdt.asl +++ b/src/mainboard/intel/baskingridge/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/cannonlake_rvp/dsdt.asl b/src/mainboard/intel/cannonlake_rvp/dsdt.asl index 5a06a45..38c21dc 100644 --- a/src/mainboard/intel/cannonlake_rvp/dsdt.asl +++ b/src/mainboard/intel/cannonlake_rvp/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/cedarisland_crb/dsdt.asl b/src/mainboard/intel/cedarisland_crb/dsdt.asl index 407ee37..a24ef28 100644 --- a/src/mainboard/intel/cedarisland_crb/dsdt.asl +++ b/src/mainboard/intel/cedarisland_crb/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/coffeelake_rvp/dsdt.asl b/src/mainboard/intel/coffeelake_rvp/dsdt.asl index 121012e..0a2163a 100644 --- a/src/mainboard/intel/coffeelake_rvp/dsdt.asl +++ b/src/mainboard/intel/coffeelake_rvp/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/d510mo/dsdt.asl b/src/mainboard/intel/d510mo/dsdt.asl index 6e4ecfc..d00a59a 100644 --- a/src/mainboard/intel/d510mo/dsdt.asl +++ b/src/mainboard/intel/d510mo/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/intel/d945gclf/dsdt.asl b/src/mainboard/intel/d945gclf/dsdt.asl index 94684d0..05f1f1a 100644 --- a/src/mainboard/intel/d945gclf/dsdt.asl +++ b/src/mainboard/intel/d945gclf/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/intel/dcp847ske/dsdt.asl b/src/mainboard/intel/dcp847ske/dsdt.asl index 737f02f..110c3ba 100644 --- a/src/mainboard/intel/dcp847ske/dsdt.asl +++ b/src/mainboard/intel/dcp847ske/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/intel/dg41wv/dsdt.asl b/src/mainboard/intel/dg41wv/dsdt.asl index fe69e95..c0f72bf 100644 --- a/src/mainboard/intel/dg41wv/dsdt.asl +++ b/src/mainboard/intel/dg41wv/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/intel/dg43gt/dsdt.asl b/src/mainboard/intel/dg43gt/dsdt.asl index de548d1..1134e4f 100644 --- a/src/mainboard/intel/dg43gt/dsdt.asl +++ b/src/mainboard/intel/dg43gt/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/intel/emeraldlake2/dsdt.asl b/src/mainboard/intel/emeraldlake2/dsdt.asl index 8b9744f..136a6e7 100644 --- a/src/mainboard/intel/emeraldlake2/dsdt.asl +++ b/src/mainboard/intel/emeraldlake2/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/galileo/dsdt.asl b/src/mainboard/intel/galileo/dsdt.asl index d18004d..27ad29e 100644 --- a/src/mainboard/intel/galileo/dsdt.asl +++ b/src/mainboard/intel/galileo/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20160220 // OEM revision diff --git a/src/mainboard/intel/glkrvp/dsdt.asl b/src/mainboard/intel/glkrvp/dsdt.asl index 315cf7c..15d1db3 100644 --- a/src/mainboard/intel/glkrvp/dsdt.asl +++ b/src/mainboard/intel/glkrvp/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/harcuvar/dsdt.asl b/src/mainboard/intel/harcuvar/dsdt.asl index 4cab4cd..d3dcf70 100644 --- a/src/mainboard/intel/harcuvar/dsdt.asl +++ b/src/mainboard/intel/harcuvar/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/icelake_rvp/dsdt.asl b/src/mainboard/intel/icelake_rvp/dsdt.asl index a3c93e2..845b14b 100644 --- a/src/mainboard/intel/icelake_rvp/dsdt.asl +++ b/src/mainboard/intel/icelake_rvp/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/jasperlake_rvp/dsdt.asl b/src/mainboard/intel/jasperlake_rvp/dsdt.asl index be883b4c..9e5edb3 100644 --- a/src/mainboard/intel/jasperlake_rvp/dsdt.asl +++ b/src/mainboard/intel/jasperlake_rvp/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/intel/kblrvp/dsdt.asl b/src/mainboard/intel/kblrvp/dsdt.asl index 354f488..3b6e7ae 100644 --- a/src/mainboard/intel/kblrvp/dsdt.asl +++ b/src/mainboard/intel/kblrvp/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/kunimitsu/dsdt.asl b/src/mainboard/intel/kunimitsu/dsdt.asl index 90a5594..44e09b9 100644 --- a/src/mainboard/intel/kunimitsu/dsdt.asl +++ b/src/mainboard/intel/kunimitsu/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/leafhill/dsdt.asl b/src/mainboard/intel/leafhill/dsdt.asl index bda108e..2c94aaa 100644 --- a/src/mainboard/intel/leafhill/dsdt.asl +++ b/src/mainboard/intel/leafhill/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/minnow3/dsdt.asl b/src/mainboard/intel/minnow3/dsdt.asl index bda108e..2c94aaa 100644 --- a/src/mainboard/intel/minnow3/dsdt.asl +++ b/src/mainboard/intel/minnow3/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/saddlebrook/dsdt.asl b/src/mainboard/intel/saddlebrook/dsdt.asl index f705b54..7b0bff4 100644 --- a/src/mainboard/intel/saddlebrook/dsdt.asl +++ b/src/mainboard/intel/saddlebrook/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/intel/strago/dsdt.asl b/src/mainboard/intel/strago/dsdt.asl index e059c82..ba45817 100644 --- a/src/mainboard/intel/strago/dsdt.asl +++ b/src/mainboard/intel/strago/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/intel/tglrvp/dsdt.asl b/src/mainboard/intel/tglrvp/dsdt.asl index e34fd58..e1c24a8 100644 --- a/src/mainboard/intel/tglrvp/dsdt.asl +++ b/src/mainboard/intel/tglrvp/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/intel/wtm2/dsdt.asl b/src/mainboard/intel/wtm2/dsdt.asl index f9d4fe8..09373e0 100644 --- a/src/mainboard/intel/wtm2/dsdt.asl +++ b/src/mainboard/intel/wtm2/dsdt.asl @@ -6,7 +6,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl index 69553cb..956a7c8 100644 --- a/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl +++ b/src/mainboard/jetway/nf81-t56n-lf/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/kontron/986lcd-m/dsdt.asl b/src/mainboard/kontron/986lcd-m/dsdt.asl index 9b5ba55..48a7ed19 100644 --- a/src/mainboard/kontron/986lcd-m/dsdt.asl +++ b/src/mainboard/kontron/986lcd-m/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/kontron/ktqm77/dsdt.asl b/src/mainboard/kontron/ktqm77/dsdt.asl index f736688..7865faf 100644 --- a/src/mainboard/kontron/ktqm77/dsdt.asl +++ b/src/mainboard/kontron/ktqm77/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/g505s/dsdt.asl b/src/mainboard/lenovo/g505s/dsdt.asl index fde51d9..a72d87c 100644 --- a/src/mainboard/lenovo/g505s/dsdt.asl +++ b/src/mainboard/lenovo/g505s/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/lenovo/l520/dsdt.asl b/src/mainboard/lenovo/l520/dsdt.asl index df39d49..85f0544 100644 --- a/src/mainboard/lenovo/l520/dsdt.asl +++ b/src/mainboard/lenovo/l520/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/lenovo/s230u/dsdt.asl b/src/mainboard/lenovo/s230u/dsdt.asl index 7633c91..fee65cb 100644 --- a/src/mainboard/lenovo/s230u/dsdt.asl +++ b/src/mainboard/lenovo/s230u/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/lenovo/t400/dsdt.asl b/src/mainboard/lenovo/t400/dsdt.asl index a1325fb..d36ec1c 100644 --- a/src/mainboard/lenovo/t400/dsdt.asl +++ b/src/mainboard/lenovo/t400/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/lenovo/t410/dsdt.asl b/src/mainboard/lenovo/t410/dsdt.asl index b794cb6..a127f21 100644 --- a/src/mainboard/lenovo/t410/dsdt.asl +++ b/src/mainboard/lenovo/t410/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20130325 /* OEM revision */ diff --git a/src/mainboard/lenovo/t420/dsdt.asl b/src/mainboard/lenovo/t420/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/t420/dsdt.asl +++ b/src/mainboard/lenovo/t420/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/t420s/dsdt.asl b/src/mainboard/lenovo/t420s/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/t420s/dsdt.asl +++ b/src/mainboard/lenovo/t420s/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/t430/dsdt.asl b/src/mainboard/lenovo/t430/dsdt.asl index 87eab8c..88d2cd7 100644 --- a/src/mainboard/lenovo/t430/dsdt.asl +++ b/src/mainboard/lenovo/t430/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/lenovo/t430s/dsdt.asl b/src/mainboard/lenovo/t430s/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/t430s/dsdt.asl +++ b/src/mainboard/lenovo/t430s/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/t440p/dsdt.asl b/src/mainboard/lenovo/t440p/dsdt.asl index 8f89092..52d14f8 100644 --- a/src/mainboard/lenovo/t440p/dsdt.asl +++ b/src/mainboard/lenovo/t440p/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI 2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/lenovo/t520/dsdt.asl b/src/mainboard/lenovo/t520/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/t520/dsdt.asl +++ b/src/mainboard/lenovo/t520/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/t530/dsdt.asl b/src/mainboard/lenovo/t530/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/t530/dsdt.asl +++ b/src/mainboard/lenovo/t530/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/t60/dsdt.asl b/src/mainboard/lenovo/t60/dsdt.asl index bddbb77..027e562 100644 --- a/src/mainboard/lenovo/t60/dsdt.asl +++ b/src/mainboard/lenovo/t60/dsdt.asl @@ -8,7 +8,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl b/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl index fe69e95..c0f72bf 100644 --- a/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl +++ b/src/mainboard/lenovo/thinkcentre_a58/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/lenovo/x131e/dsdt.asl b/src/mainboard/lenovo/x131e/dsdt.asl index 3affa49..793f45a 100644 --- a/src/mainboard/lenovo/x131e/dsdt.asl +++ b/src/mainboard/lenovo/x131e/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl b/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl index 85a9767..d1c60c5 100644 --- a/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl +++ b/src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl @@ -10,7 +10,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/lenovo/x200/dsdt.asl b/src/mainboard/lenovo/x200/dsdt.asl index 8ab71c8..7269506 100644 --- a/src/mainboard/lenovo/x200/dsdt.asl +++ b/src/mainboard/lenovo/x200/dsdt.asl @@ -8,7 +8,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/lenovo/x201/dsdt.asl b/src/mainboard/lenovo/x201/dsdt.asl index b794cb6..a127f21 100644 --- a/src/mainboard/lenovo/x201/dsdt.asl +++ b/src/mainboard/lenovo/x201/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20130325 /* OEM revision */ diff --git a/src/mainboard/lenovo/x220/dsdt.asl b/src/mainboard/lenovo/x220/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/x220/dsdt.asl +++ b/src/mainboard/lenovo/x220/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/x230/dsdt.asl b/src/mainboard/lenovo/x230/dsdt.asl index b83fe38..70726bc 100644 --- a/src/mainboard/lenovo/x230/dsdt.asl +++ b/src/mainboard/lenovo/x230/dsdt.asl @@ -9,7 +9,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/lenovo/x60/dsdt.asl b/src/mainboard/lenovo/x60/dsdt.asl index 8919ead..828427b 100644 --- a/src/mainboard/lenovo/x60/dsdt.asl +++ b/src/mainboard/lenovo/x60/dsdt.asl @@ -8,7 +8,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/libretrend/lt1000/dsdt.asl b/src/mainboard/libretrend/lt1000/dsdt.asl index 5b3a5df..eafc77e 100644 --- a/src/mainboard/libretrend/lt1000/dsdt.asl +++ b/src/mainboard/libretrend/lt1000/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/lippert/frontrunner-af/dsdt.asl b/src/mainboard/lippert/frontrunner-af/dsdt.asl index 8c9a6b5..a9fd9af 100644 --- a/src/mainboard/lippert/frontrunner-af/dsdt.asl +++ b/src/mainboard/lippert/frontrunner-af/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/msi/ms7707/dsdt.asl b/src/mainboard/msi/ms7707/dsdt.asl index 0a57964..b4f75c9 100644 --- a/src/mainboard/msi/ms7707/dsdt.asl +++ b/src/mainboard/msi/ms7707/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI 2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/msi/ms7721/dsdt.asl b/src/mainboard/msi/ms7721/dsdt.asl index 7c8f6aa..d5cc2ed 100644 --- a/src/mainboard/msi/ms7721/dsdt.asl +++ b/src/mainboard/msi/ms7721/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/ocp/deltalake/dsdt.asl b/src/mainboard/ocp/deltalake/dsdt.asl index c74b5fe..2fc5029 100644 --- a/src/mainboard/ocp/deltalake/dsdt.asl +++ b/src/mainboard/ocp/deltalake/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/ocp/tiogapass/dsdt.asl b/src/mainboard/ocp/tiogapass/dsdt.asl index bd31251..1e5c523 100644 --- a/src/mainboard/ocp/tiogapass/dsdt.asl +++ b/src/mainboard/ocp/tiogapass/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/packardbell/ms2290/dsdt.asl b/src/mainboard/packardbell/ms2290/dsdt.asl index f175707..5f3908d 100644 --- a/src/mainboard/packardbell/ms2290/dsdt.asl +++ b/src/mainboard/packardbell/ms2290/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20140108 /* OEM revision */ diff --git a/src/mainboard/pcengines/apu1/dsdt.asl b/src/mainboard/pcengines/apu1/dsdt.asl index 592c6ba..b42d43e 100644 --- a/src/mainboard/pcengines/apu1/dsdt.asl +++ b/src/mainboard/pcengines/apu1/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/pcengines/apu2/dsdt.asl b/src/mainboard/pcengines/apu2/dsdt.asl index 7e106c2..e93f860 100644 --- a/src/mainboard/pcengines/apu2/dsdt.asl +++ b/src/mainboard/pcengines/apu2/dsdt.asl @@ -5,7 +5,7 @@ DefinitionBlock ( "DSDT.AML", /* Output filename */ "DSDT", /* Signature */ - 0x02, /* DSDT Revision, needs to be 2 for 64bit */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM Revision */ diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl index ec105e4..a8598ab 100644 --- a/src/mainboard/portwell/m107/dsdt.asl +++ b/src/mainboard/portwell/m107/dsdt.asl @@ -7,7 +7,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/prodrive/hermes/dsdt.asl b/src/mainboard/prodrive/hermes/dsdt.asl index 4d8d170..58a0fed 100644 --- a/src/mainboard/prodrive/hermes/dsdt.asl +++ b/src/mainboard/prodrive/hermes/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/protectli/vault_bsw/dsdt.asl b/src/mainboard/protectli/vault_bsw/dsdt.asl index c5e2ed3..246bc26 100644 --- a/src/mainboard/protectli/vault_bsw/dsdt.asl +++ b/src/mainboard/protectli/vault_bsw/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001 /* OEM revision */ diff --git a/src/mainboard/protectli/vault_kbl/dsdt.asl b/src/mainboard/protectli/vault_kbl/dsdt.asl index 5b3a5df..eafc77e 100644 --- a/src/mainboard/protectli/vault_kbl/dsdt.asl +++ b/src/mainboard/protectli/vault_kbl/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/purism/librem_bdw/dsdt.asl b/src/mainboard/purism/librem_bdw/dsdt.asl index 5053a7d..89294d8 100644 --- a/src/mainboard/purism/librem_bdw/dsdt.asl +++ b/src/mainboard/purism/librem_bdw/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20160115 /* OEM revision */ diff --git a/src/mainboard/purism/librem_skl/dsdt.asl b/src/mainboard/purism/librem_skl/dsdt.asl index dacfeff..a2faae6 100644 --- a/src/mainboard/purism/librem_skl/dsdt.asl +++ b/src/mainboard/purism/librem_skl/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/purism/librem_whl/dsdt.asl b/src/mainboard/purism/librem_whl/dsdt.asl index 296be17..363c95c 100644 --- a/src/mainboard/purism/librem_whl/dsdt.asl +++ b/src/mainboard/purism/librem_whl/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 /* OEM revision */ diff --git a/src/mainboard/roda/rk886ex/dsdt.asl b/src/mainboard/roda/rk886ex/dsdt.asl index 997db33..5935a9d 100644 --- a/src/mainboard/roda/rk886ex/dsdt.asl +++ b/src/mainboard/roda/rk886ex/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/roda/rk9/dsdt.asl b/src/mainboard/roda/rk9/dsdt.asl index 52784af..4f6e0fb 100644 --- a/src/mainboard/roda/rk9/dsdt.asl +++ b/src/mainboard/roda/rk9/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20090419 // OEM revision diff --git a/src/mainboard/roda/rv11/dsdt.asl b/src/mainboard/roda/rv11/dsdt.asl index c87a947..85d483a 100644 --- a/src/mainboard/roda/rv11/dsdt.asl +++ b/src/mainboard/roda/rv11/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/samsung/lumpy/dsdt.asl b/src/mainboard/samsung/lumpy/dsdt.asl index 0d9c7dd..e9226ca 100644 --- a/src/mainboard/samsung/lumpy/dsdt.asl +++ b/src/mainboard/samsung/lumpy/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/samsung/stumpy/dsdt.asl b/src/mainboard/samsung/stumpy/dsdt.asl index 84c50eb..8b72f24 100644 --- a/src/mainboard/samsung/stumpy/dsdt.asl +++ b/src/mainboard/samsung/stumpy/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl index 94ff303..9b61cde 100644 --- a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl +++ b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20141018 // OEM revision diff --git a/src/mainboard/scaleway/tagada/dsdt.asl b/src/mainboard/scaleway/tagada/dsdt.asl index 4cab4cd..d3dcf70 100644 --- a/src/mainboard/scaleway/tagada/dsdt.asl +++ b/src/mainboard/scaleway/tagada/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/siemens/mc_apl1/dsdt.asl b/src/mainboard/siemens/mc_apl1/dsdt.asl index bbce6ab..f760549 100644 --- a/src/mainboard/siemens/mc_apl1/dsdt.asl +++ b/src/mainboard/siemens/mc_apl1/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl index f705b54..7b0bff4 100644 --- a/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl +++ b/src/mainboard/supermicro/x11-lga1151-series/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/supermicro/x9scl/dsdt.asl b/src/mainboard/supermicro/x9scl/dsdt.asl index a46e27f..4ca8453 100644 --- a/src/mainboard/supermicro/x9scl/dsdt.asl +++ b/src/mainboard/supermicro/x9scl/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, /* DSDT Revision: ACPI v2.0 and up */ + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20171231 /* OEM Revision */ diff --git a/src/mainboard/system76/lemp9/dsdt.asl b/src/mainboard/system76/lemp9/dsdt.asl index eac27b5..a611463 100644 --- a/src/mainboard/system76/lemp9/dsdt.asl +++ b/src/mainboard/system76/lemp9/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision diff --git a/src/mainboard/up/squared/dsdt.asl b/src/mainboard/up/squared/dsdt.asl index bda108e..2c94aaa 100644 --- a/src/mainboard/up/squared/dsdt.asl +++ b/src/mainboard/up/squared/dsdt.asl @@ -4,7 +4,7 @@ DefinitionBlock( "dsdt.aml", "DSDT", - 0x02, // DSDT revision: ACPI v2.0 and up + CURRENT_DSDT_REV, OEM_ID, ACPI_TABLE_CREATOR, 0x20110725 // OEM revision
Hello Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Evgeny Zinoviev, Alexander Couzens, Werner Zeh, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#2).
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
Define DSDT revision and use it.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl M util/autoport/main.go 162 files changed, 162 insertions(+), 161 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/2
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3: Code-Review+1
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3: Code-Review+1
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */ I have two questions: 1. In many of the dsdt.asl files there is one additional statement in the comment: "...needs to be 2 for 64bit". With this change this comment is gone now. Is this something you are aware of? Shall we keep this information or is it that old now so that everybody is aware of that? 2. If you look a bit down this file you can see how the FADT table versions are handled:
/* FADT TABLE Revision values */ #define ACPI_FADT_REV_ACPI_1_0 1 #define ACPI_FADT_REV_ACPI_2_0 3 #define ACPI_FADT_REV_ACPI_3_0 4 #define ACPI_FADT_REV_ACPI_4_0 4 #define ACPI_FADT_REV_ACPI_5_0 5 #define ACPI_FADT_REV_ACPI_6_0 6
Would it make more sense to adapt this scheme so that in the future (if needed) a mainboard can select a different version? Or are you sure that the DSDT will have the same version among the complete tree all the time in future?
For instance we already have src/mainboard/razer/blade_stealth_kbl/dsdt.asl and /src/mainboard/51nb/x210/dsdt.asl with a DSDT version of 0x5.
At least I would like to see the typical "ACPI_" prefix in this define as usually done in this file.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
I have two questions: […]
So we've been copy-pasting the wrong DSDT revision all the time?
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3:
And btw: You seem to have missed at least src/mainboard/supermicro/x10slm-f/dsdt.asl as this file have the header defined on one line which was not caught by your regexp.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3:
Patch Set 3:
And btw: You seem to have missed at least src/mainboard/supermicro/x10slm-f/dsdt.asl as this file have the header defined on one line which was not caught by your regexp.
And src/mainboard/asus/p2b/dsdt.asl, same here.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
Patch Set 3:
And btw: You seem to have missed at least src/mainboard/supermicro/x10slm-f/dsdt.asl as this file have the header defined on one line which was not caught by your regexp.
And src/mainboard/asus/p2b/dsdt.asl, same here.
please see https://review.coreboot.org/c/coreboot/+/45791/1
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
So we've been copy-pasting the wrong DSDT revision all the time?
DSDT revision is not ACPI_FADT_REV_ACPI_xx...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
DSDT revision is not ACPI_FADT_REV_ACPI_xx...
You're right, sorry. I must have read things from /dev/urandom instead of from the monitor
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Werner Zeh, Evgeny Zinoviev, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#4).
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
Define DSDT revision according to ACPI specification 6.3 - January 2019 page #150 Table 5-41 Differentiated System Description Table Fields (DSDT)": DSDT rivison: "2 This field also sets the global integer width for the AML interpreter. Values less than two will cause the interpreter to use 32-bit integers and math. Values of two and greater will cause the interpreter to use full 64-bit integers and math."
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl M util/autoport/main.go 162 files changed, 162 insertions(+), 161 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/4
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
DSDT revision is not ACPI_FADT_REV_ACPI_xx...
Yes, I am aware of that. What I would rather like to see is something like this:
/* DSDT TABLE Revision values */ #define ACPI_DSDT_REV_ACPI_1_0 1 #define ACPI_DSDT_REV_ACPI_2_0 2 #define ACPI_DSDT_REV_ACPI_5_0 5 ...
Just to follow the scheme and make it look more common.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
And btw: You seem to have missed at least src/mainboard/supermicro/x10slm-f/dsdt.asl as this file have the header defined on one line which was not caught by your regexp.
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
DSDT revision is not ACPI_FADT_REV_ACPI_xx... […]
used values are 1 or 2 (or grater, but same as 2) for legacy ACPI : 1 and for current it is 2. in fact, I want make the difference between ACPI version and DSDT rev.
(see also https://review.coreboot.org/c/coreboot/+/45786 )
is this ok ? : #define ACPI_LEGACY_DSDT_REV 1 #define ACPI_CURRENT_DSDT_REV 2
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
used values are 1 or 2 (or grater, but same as 2) […]
I just had a short look at ACPI specs v3.0, 4.0, 5.0 and 6.3 (current one). It looks like the revision of DSDT is fixed to 2 since at least ACPI version 3.0. This text can be found in the spec for the revision: "2. This field also sets the global integer width for the AML interpreter. Values less than two will cause the interpreter to use 32-bit integers and math. Values of two and greater will cause the interpreter to use full 64-bit integers and math."
Which explains the 64 bit comment in the mainboards.
Sorry for being bad prepared and yes, your suggested defines would be fine for me.
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Werner Zeh, Evgeny Zinoviev, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#5).
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro
Define DSDT revision according to ACPI specification 6.3 - January 2019 page #150 Table 5-41 Differentiated System Description Table Fields (DSDT)": DSDT rivison: "2 This field also sets the global integer width for the AML interpreter. Values less than two will cause the interpreter to use 32-bit integers and math. Values of two and greater will cause the interpreter to use full 64-bit integers and math."
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl M util/autoport/main.go 162 files changed, 162 insertions(+), 161 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/5
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce CURRENT_DSDT_REV macro ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45751/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45751/4//COMMIT_MSG@9 PS4, Line 9: Define DSDT revision according to ACPI specification 6.3 - January 2019 : page #150 Table 5-41 Differentiated System Description Table Fields (DSDT)": : DSDT rivison: : "2 This field also sets the global integer width for the AML : interpreter. Values less than two will cause the interpreter to : use 32-bit integers and math. Values of two and greater will : cause the interpreter to use full 64-bit integers and math." Please describe the change instead. The spec doesn't matter as the commit doesn't seem to change the number. AFAICS, it's only a cosmetic change, i.e. replacing 2 with a macro. This should be mentioned at least so reviewers know what to look for.
Also mention the incentive. What is better after the change? (e.g. we can then easier adapt all boards at once, which might be nice if we ever want to)
https://review.coreboot.org/c/coreboot/+/45751/4/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/4/src/include/acpi/acpi.h@44 PS4, Line 44: CURRENT_DSDT_REV The "current" in the name seems to imply that we might update this in the future and if we do we'd do it for all boards? As we don't know what a possible future `3` would imply (at least I'm not an oracle), how can we predict if this would make sense?
The name should at least reflect the number. Otherwise, this change makes 161 files less readable, i.e. one has to look up then what CURRENT_DSDT_REV is when reading one of these files.
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Werner Zeh, Evgeny Zinoviev, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#6).
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro
Replace DSDT revison number with macro so we can adapt all boards at once if needed.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl M util/autoport/main.go 162 files changed, 162 insertions(+), 161 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/6
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/6/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/6/src/include/acpi/acpi.h@44 PS6, Line 44: ACPI_DSDT_REV_2 Exactly what I was targeting originally. Thank you.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45751/6/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/6/src/include/acpi/acpi.h@44 PS6, Line 44: ACPI_DSDT_REV_2
Exactly what I was targeting originally. Thank you.
Done
https://review.coreboot.org/c/coreboot/+/45751/4/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/4/src/include/acpi/acpi.h@44 PS4, Line 44: CURRENT_DSDT_REV
The "current" in the name seems to imply that we might update this in the […]
Done
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/45751/3/src/include/acpi/acpi.h@44 PS3, Line 44: #define CURRENT_DSDT_REV 0x02 /* DSDT revision: ACPI v2.0 and greater */
I just had a short look at ACPI specs v3.0, 4.0, 5.0 and 6.3 (current one). […]
Done
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45751/4//COMMIT_MSG@9 PS4, Line 9: Define DSDT revision according to ACPI specification 6.3 - January 2019 : page #150 Table 5-41 Differentiated System Description Table Fields (DSDT)": : DSDT rivison: : "2 This field also sets the global integer width for the AML : interpreter. Values less than two will cause the interpreter to : use 32-bit integers and math. Values of two and greater will : cause the interpreter to use full 64-bit integers and math."
Please describe the change instead. The spec doesn't matter as the […]
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45751/6//COMMIT_MSG@9 PS6, Line 9: all missing acer/g43t-am3
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45751/6//COMMIT_MSG@9 PS6, Line 9: all
missing acer/g43t-am3
Done Thx
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Werner Zeh, Evgeny Zinoviev, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#7).
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro
Replace DSDT revison number with macro so we can adapt boards at once if needed. See flowing patchs for "missing" boards.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl M util/autoport/main.go 162 files changed, 162 insertions(+), 161 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/7
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Werner Zeh, Evgeny Zinoviev, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#8).
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro
Replace DSDT revison number with macro so we can adapt all boards at once if needed.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h M src/mainboard/amd/gardenia/dsdt.asl M src/mainboard/amd/inagua/dsdt.asl M src/mainboard/amd/mandolin/dsdt.asl M src/mainboard/amd/olivehill/dsdt.asl M src/mainboard/amd/padmelon/dsdt.asl M src/mainboard/amd/parmer/dsdt.asl M src/mainboard/amd/persimmon/dsdt.asl M src/mainboard/amd/south_station/dsdt.asl M src/mainboard/amd/thatcher/dsdt.asl M src/mainboard/amd/union_station/dsdt.asl M src/mainboard/aopen/dxplplusu/dsdt.asl M src/mainboard/apple/macbook21/dsdt.asl M src/mainboard/apple/macbookair4_2/dsdt.asl M src/mainboard/asrock/b75pro3-m/dsdt.asl M src/mainboard/asrock/b85m_pro4/dsdt.asl M src/mainboard/asrock/e350m1/dsdt.asl M src/mainboard/asrock/g41c-gs/dsdt.asl M src/mainboard/asrock/h110m/dsdt.asl M src/mainboard/asrock/h81m-hds/dsdt.asl M src/mainboard/asrock/imb-a180/dsdt.asl M src/mainboard/asus/a88xm-e/dsdt.asl M src/mainboard/asus/am1i-a/dsdt.asl M src/mainboard/asus/f2a85-m/dsdt.asl M src/mainboard/asus/h61m-cs/dsdt.asl M src/mainboard/asus/maximus_iv_gene-z/dsdt.asl M src/mainboard/asus/p5gc-mx/dsdt.asl M src/mainboard/asus/p5qc/dsdt.asl M src/mainboard/asus/p5ql-em/dsdt.asl M src/mainboard/asus/p5qpl-am/dsdt.asl M src/mainboard/asus/p8h61-m_lx/dsdt.asl M src/mainboard/asus/p8h61-m_lx3_r2_0/dsdt.asl M src/mainboard/asus/p8h61-m_pro/dsdt.asl M src/mainboard/asus/p8z77-m_pro/dsdt.asl M src/mainboard/asus/p8z77-v_lx2/dsdt.asl M src/mainboard/bap/ode_e20XX/dsdt.asl M src/mainboard/biostar/a68n_5200/dsdt.asl M src/mainboard/biostar/am1ml/dsdt.asl M src/mainboard/biostar/th61-itx/dsdt.asl M src/mainboard/bostentech/gbyt4/dsdt.asl M src/mainboard/clevo/cml-u/dsdt.asl M src/mainboard/compulab/intense_pc/dsdt.asl M src/mainboard/dell/optiplex_9010/dsdt.asl M src/mainboard/elmex/pcm205400/dsdt.asl M src/mainboard/facebook/fbg1701/dsdt.asl M src/mainboard/facebook/monolith/dsdt.asl M src/mainboard/foxconn/d41s/dsdt.asl M src/mainboard/foxconn/g41s-k/dsdt.asl M src/mainboard/getac/p470/dsdt.asl M src/mainboard/gigabyte/ga-945gcm-s2l/dsdt.asl M src/mainboard/gigabyte/ga-b75m-d3h/dsdt.asl M src/mainboard/gigabyte/ga-g41m-es2l/dsdt.asl M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl M src/mainboard/gizmosphere/gizmo/dsdt.asl M src/mainboard/gizmosphere/gizmo2/dsdt.asl M src/mainboard/google/auron/dsdt.asl M src/mainboard/google/beltino/dsdt.asl M src/mainboard/google/butterfly/dsdt.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/google/dedede/dsdt.asl M src/mainboard/google/deltaur/dsdt.asl M src/mainboard/google/drallion/dsdt.asl M src/mainboard/google/eve/dsdt.asl M src/mainboard/google/fizz/dsdt.asl M src/mainboard/google/glados/dsdt.asl M src/mainboard/google/hatch/dsdt.asl M src/mainboard/google/jecht/dsdt.asl M src/mainboard/google/kahlee/dsdt.asl M src/mainboard/google/link/dsdt.asl M src/mainboard/google/octopus/dsdt.asl M src/mainboard/google/parrot/dsdt.asl M src/mainboard/google/poppy/dsdt.asl M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/reef/dsdt.asl M src/mainboard/google/sarien/dsdt.asl M src/mainboard/google/slippy/dsdt.asl M src/mainboard/google/stout/dsdt.asl M src/mainboard/google/volteer/dsdt.asl M src/mainboard/google/zork/dsdt.asl M src/mainboard/hp/abm/dsdt.asl M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl M src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl M src/mainboard/hp/snb_ivb_laptops/dsdt.asl M src/mainboard/hp/z220_sff_workstation/dsdt.asl M src/mainboard/ibase/mb899/dsdt.asl M src/mainboard/intel/apollolake_rvp/dsdt.asl M src/mainboard/intel/baskingridge/dsdt.asl M src/mainboard/intel/cannonlake_rvp/dsdt.asl M src/mainboard/intel/cedarisland_crb/dsdt.asl M src/mainboard/intel/coffeelake_rvp/dsdt.asl M src/mainboard/intel/d510mo/dsdt.asl M src/mainboard/intel/d945gclf/dsdt.asl M src/mainboard/intel/dcp847ske/dsdt.asl M src/mainboard/intel/dg41wv/dsdt.asl M src/mainboard/intel/dg43gt/dsdt.asl M src/mainboard/intel/emeraldlake2/dsdt.asl M src/mainboard/intel/galileo/dsdt.asl M src/mainboard/intel/glkrvp/dsdt.asl M src/mainboard/intel/harcuvar/dsdt.asl M src/mainboard/intel/icelake_rvp/dsdt.asl M src/mainboard/intel/jasperlake_rvp/dsdt.asl M src/mainboard/intel/kblrvp/dsdt.asl M src/mainboard/intel/kunimitsu/dsdt.asl M src/mainboard/intel/leafhill/dsdt.asl M src/mainboard/intel/minnow3/dsdt.asl M src/mainboard/intel/saddlebrook/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/intel/tglrvp/dsdt.asl M src/mainboard/intel/wtm2/dsdt.asl M src/mainboard/jetway/nf81-t56n-lf/dsdt.asl M src/mainboard/kontron/986lcd-m/dsdt.asl M src/mainboard/kontron/ktqm77/dsdt.asl M src/mainboard/lenovo/g505s/dsdt.asl M src/mainboard/lenovo/l520/dsdt.asl M src/mainboard/lenovo/s230u/dsdt.asl M src/mainboard/lenovo/t400/dsdt.asl M src/mainboard/lenovo/t410/dsdt.asl M src/mainboard/lenovo/t420/dsdt.asl M src/mainboard/lenovo/t420s/dsdt.asl M src/mainboard/lenovo/t430/dsdt.asl M src/mainboard/lenovo/t430s/dsdt.asl M src/mainboard/lenovo/t440p/dsdt.asl M src/mainboard/lenovo/t520/dsdt.asl M src/mainboard/lenovo/t530/dsdt.asl M src/mainboard/lenovo/t60/dsdt.asl M src/mainboard/lenovo/thinkcentre_a58/dsdt.asl M src/mainboard/lenovo/x131e/dsdt.asl M src/mainboard/lenovo/x1_carbon_gen1/dsdt.asl M src/mainboard/lenovo/x200/dsdt.asl M src/mainboard/lenovo/x201/dsdt.asl M src/mainboard/lenovo/x220/dsdt.asl M src/mainboard/lenovo/x230/dsdt.asl M src/mainboard/lenovo/x60/dsdt.asl M src/mainboard/libretrend/lt1000/dsdt.asl M src/mainboard/lippert/frontrunner-af/dsdt.asl M src/mainboard/msi/ms7707/dsdt.asl M src/mainboard/msi/ms7721/dsdt.asl M src/mainboard/ocp/deltalake/dsdt.asl M src/mainboard/ocp/tiogapass/dsdt.asl M src/mainboard/packardbell/ms2290/dsdt.asl M src/mainboard/pcengines/apu1/dsdt.asl M src/mainboard/pcengines/apu2/dsdt.asl M src/mainboard/portwell/m107/dsdt.asl M src/mainboard/prodrive/hermes/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/protectli/vault_kbl/dsdt.asl M src/mainboard/purism/librem_bdw/dsdt.asl M src/mainboard/purism/librem_skl/dsdt.asl M src/mainboard/purism/librem_whl/dsdt.asl M src/mainboard/roda/rk886ex/dsdt.asl M src/mainboard/roda/rk9/dsdt.asl M src/mainboard/roda/rv11/dsdt.asl M src/mainboard/samsung/lumpy/dsdt.asl M src/mainboard/samsung/stumpy/dsdt.asl M src/mainboard/sapphire/pureplatinumh61/dsdt.asl M src/mainboard/scaleway/tagada/dsdt.asl M src/mainboard/siemens/mc_apl1/dsdt.asl M src/mainboard/supermicro/x11-lga1151-series/dsdt.asl M src/mainboard/supermicro/x9scl/dsdt.asl M src/mainboard/system76/lemp9/dsdt.asl M src/mainboard/up/squared/dsdt.asl M util/autoport/main.go 162 files changed, 162 insertions(+), 161 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/8
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: src/{include/acpi,mainboard}: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45751/7//COMMIT_MSG@11 PS7, Line 11: See flowing patchs for "missing" boards. Just squash the commits and drop this. I'll +2.
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Jeremy Soller, Angel Pons, Patrick Rudolph, Piotr Król, Michał Żygowski, David Guckian, Vanessa Eusebio, Werner Zeh, Evgeny Zinoviev, Alexander Couzens, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45751
to look at the new patch set (#9).
Change subject: include/acpi/acpi.h: Introduce ACPI_DSDT_REV_2 macro ......................................................................
include/acpi/acpi.h: Introduce ACPI_DSDT_REV_2 macro
This to replace DSDT revison number with macro so we can adapt all boards at once if needed.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/45751/9
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: include/acpi/acpi.h: Introduce ACPI_DSDT_REV_2 macro ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45751/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45751/7//COMMIT_MSG@11 PS7, Line 11: See flowing patchs for "missing" boards.
Just squash the commits and drop this. I'll +2.
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45751 )
Change subject: include/acpi/acpi.h: Introduce ACPI_DSDT_REV_2 macro ......................................................................
include/acpi/acpi.h: Introduce ACPI_DSDT_REV_2 macro
This to replace DSDT revison number with macro so we can adapt all boards at once if needed.
Change-Id: I9e92a5f408f69aa1a6801bc2cba8ddfe2180b040 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/45751 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/include/acpi/acpi.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 53308f3..7b0f339 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -41,6 +41,7 @@
#define ACPI_TABLE_CREATOR "COREBOOT" /* Must be exactly 8 bytes long! */ #define OEM_ID "COREv4" /* Must be exactly 6 bytes long! */ +#define ACPI_DSDT_REV_2 0x02 /* DSDT revision: ACPI v2.0 and greater */
#if !defined(__ASSEMBLER__) && !defined(__ACPI__) #include <commonlib/helpers.h>
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)
-
Wim Vervoorn (Code Review)