Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully. For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo, and observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 10 files changed, 48 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/1
diff --git a/util/mainboard/google/hatch/template/Makefile.inc b/util/mainboard/google/hatch/template/Makefile.inc index 61b23ed..599cfcc 100644 --- a/util/mainboard/google/hatch/template/Makefile.inc +++ b/util/mainboard/google/hatch/template/Makefile.inc @@ -1,4 +1,6 @@ ## ## SPDX-License-Identifier: GPL-2.0-only
-SPD_SOURCES = +## TODO engineer creating a new variant needs to add SPDs for memory parts + +SPD_SOURCES = empty_ddr4 diff --git a/util/mainboard/google/volteer/template/memory/Makefile.inc b/util/mainboard/google/volteer/template/memory/Makefile.inc new file mode 100644 index 0000000..3edeb96 --- /dev/null +++ b/util/mainboard/google/volteer/template/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = ddr4-spd-empty.hex diff --git a/util/mainboard/google/volteer/template/memory/dram_id.generated.txt b/util/mainboard/google/volteer/template/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/volteer/template/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/volteer/template/memory/mem_parts_used.txt b/util/mainboard/google/volteer/template/memory/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/volteer/template/memory/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional) diff --git a/util/mainboard/google/waddledee/template/memory/Makefile.inc b/util/mainboard/google/waddledee/template/memory/Makefile.inc new file mode 100644 index 0000000..3edeb96 --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = ddr4-spd-empty.hex diff --git a/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt b/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt b/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional) diff --git a/util/mainboard/google/waddledoo/template/memory/Makefile.inc b/util/mainboard/google/waddledoo/template/memory/Makefile.inc new file mode 100644 index 0000000..3edeb96 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = ddr4-spd-empty.hex diff --git a/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt b/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt b/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional)
Paul Fagerburg has removed Karthikeyan Ramasubramanian from this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Removed reviewer Karthikeyan Ramasubramanian.
Paul Fagerburg has removed Nick Vaccaro from this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Removed reviewer Nick Vaccaro.
Hello Furquan Shaikh, Patrick Georgi, Martin Roth, Nick Vaccaro, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#2).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully. For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 10 files changed, 48 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45746/2//COMMIT_MSG@12 PS2, Line 12: For variants that use spd_tools, add an empty mem_parts_used.txt so Please add a blank line between paragraphs.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 4: ddr4 Volteer boards can use LPDDR4x or DDR4 memories. How do you plan to handle that?
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 9: , Fixed ID (optional) Just a note: This is not supported by LPDDR4x tool. We should add that support, but it is not present right now.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4 Dedede boards do not use DDR4 memory.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45746/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45746/2//COMMIT_MSG@12 PS2, Line 12: For variants that use spd_tools, add an empty mem_parts_used.txt so
Please add a blank line between paragraphs.
Done
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 4: ddr4
Volteer boards can use LPDDR4x or DDR4 memories. […]
I'll update the file to remove the comments that suggest that only DDR4 is supported.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/volte... PS2, Line 9: , Fixed ID (optional)
Just a note: This is not supported by LPDDR4x tool. […]
I copied this one from Zork. I'll remove references to the Fixed ID and also the implication that only DDR4 is supported.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4
Dedede boards do not use DDR4 memory.
There is no "empty" SPD for lpddr4x. I just need a placeholder here. Is the comment above (use spd_tools to regenerate this file) not enough?
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Nick Vaccaro, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#3).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 10 files changed, 44 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/3
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Nick Vaccaro, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#4).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 10 files changed, 43 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/hatch... File util/mainboard/google/hatch/template/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/hatch... PS4, Line 1: ## nit: this seems to be a leftover from conversion to SPDX
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... PS4, Line 3: ddr4 This still refers to ddr4. Probably say either of the DDR4 or LP4x depending upon the memory type being used by the variant?
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... PS4, Line 4: ddr4 Same here.
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4
There is no "empty" SPD for lpddr4x. I just need a placeholder here. […]
I think we should add a empty SPD for LP4x in that case. It is confusing that the default used a SPD file referencing DDR4 but the platform really uses LP4x.
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/mem_parts_used.txt:
PS4: Same comments here as for waddledoo.
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... PS4, Line 4: ddr4 This is still incorrect. Dedede boards do not use DDR4 memory.
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... PS4, Line 9: , Fixed ID (optional) Let's not add this by default. Ideally we should not be using that at all. It can be added if/when a variant really needs it.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Angel Pons, Nick Vaccaro, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#5).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
Add an empty SPD for LPDDR4x for waddledee and waddledoo to use.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- A src/soc/intel/jasperlake/spd/empty.spd.hex M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 11 files changed, 69 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/5
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 4:
(6 comments)
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... PS4, Line 3: ddr4
This still refers to ddr4. […]
Done
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/volte... PS4, Line 4: ddr4
Same here.
Done
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/2/util/mainboard/google/waddl... PS2, Line 5: ddr4
I think we should add a empty SPD for LP4x in that case. […]
Done
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/mem_parts_used.txt:
PS4:
Same comments here as for waddledoo.
Done
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... File util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt:
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... PS4, Line 4: ddr4
This is still incorrect. Dedede boards do not use DDR4 memory.
Done
https://review.coreboot.org/c/coreboot/+/45746/4/util/mainboard/google/waddl... PS4, Line 9: , Fixed ID (optional)
Let's not add this by default. Ideally we should not be using that at all. […]
Done
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/5/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/5/util/mainboard/google/volte... PS5, Line 5: ddr4 FYI, Volteer can be either LPDDR4x or DDR4. We are probably ok here as the SPD for an LPDDR4x and an SPD for DDR4 are the same size. Can we use a common name that doesn't imply ddr4 for the empty spd filename?
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/5/util/mainboard/google/volte... File util/mainboard/google/volteer/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/5/util/mainboard/google/volte... PS5, Line 5: ddr4
FYI, Volteer can be either LPDDR4x or DDR4. […]
Done
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Angel Pons, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#6).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
Add an empty SPD for LPDDR4x for waddledee and waddledoo to use.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- A src/soc/intel/jasperlake/spd/empty.spd.hex R src/soc/intel/tigerlake/spd/empty.spd.hex M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 12 files changed, 69 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 6:
I have posted a comment on https://review.coreboot.org/c/coreboot/+/45131 to see if we should get rid of the check for empty SPD_SOURCES.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 6:
Patch Set 6:
I have posted a comment on https://review.coreboot.org/c/coreboot/+/45131 to see if we should get rid of the check for empty SPD_SOURCES.
I'm in favor of reverting that CL, which would let me abandon that one.
But, one small point in favor of keeping it is that this CL sets up the mem_parts_used.txt for the engineer to start filling it in, instead of making them create that file.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45746/6/src/soc/intel/jasperlake/sp... File src/soc/intel/jasperlake/spd/empty.spd.hex:
PS6: Rather than using the empty.spd.hex, can we please add placeholder.spd.hex - Reason I say this is because SoC might support different memory technologies. And the SPD for each of these might differ in size. Since empty.spd.hex gets used even when there are gaps in DRAM strap ID allocation, I think it would be safer to have empty-ddr4, empty-lpddr4 files rather than a single empty.spd.hex which can result in silent failures later. And for the case of initial variant creation, we can use placeholder.spd.hex which we know should not be used any time later.
Next steps: 1. Add placeholder.spd.hex/placeholder_spd to tigerlake and jasperlake (Ideally we can get rid of the duplicate files under each SoC once we move SPDs out of the SoC directory) - This can in fact be just 1 byte in size. 2. Use placeholder SPDs for initial variant creation.
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... PS6, Line 5: .spd.hex I think you don't need the .spd.hex suffix here?
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45746/6/src/soc/intel/jasperlake/sp... File src/soc/intel/jasperlake/spd/empty.spd.hex:
PS6:
Rather than using the empty.spd.hex, can we please add placeholder.spd. […]
Done
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... PS6, Line 5: .spd.hex
I think you don't need the .spd. […]
All of the memory/Makefile.inc for the variants use the full filename of the SPD, including the .hex extension.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Angel Pons, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#7).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
Add an empty SPD for LPDDR4x for waddledee and waddledoo to use.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- A src/soc/intel/jasperlake/spd/placeholder.spd.hex R src/soc/intel/tigerlake/spd/placeholder.spd.hex M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 12 files changed, 69 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/7
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/7/src/soc/intel/tigerlake/spd... File src/soc/intel/tigerlake/spd/placeholder.spd.hex:
PS7: ddr4-spd-empty.hex still needs to exist. Instead of rename, you will have to add a new placeholder.spd.hex
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... File util/mainboard/google/waddledee/template/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45746/6/util/mainboard/google/waddl... PS6, Line 5: .spd.hex
All of the memory/Makefile.inc for the variants use the full filename of the SPD, including the . […]
Ack.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Angel Pons, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#8).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
Add an empty SPD for LPDDR4x for waddledee and waddledoo to use.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- A src/soc/intel/jasperlake/spd/placeholder.spd.hex R src/soc/intel/tigerlake/spd/ddr4-empty-spd.hex C src/soc/intel/tigerlake/spd/placeholder.spd.hex M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 13 files changed, 69 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/8
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/7/src/soc/intel/tigerlake/spd... File src/soc/intel/tigerlake/spd/placeholder.spd.hex:
PS7:
ddr4-spd-empty.hex still needs to exist. Instead of rename, you will have to add a new placeholder. […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/8/src/soc/intel/tigerlake/spd... File src/soc/intel/tigerlake/spd/ddr4-empty-spd.hex:
PS8: Why is this file rename a part of this change? It is not related anymore.
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/8/src/soc/intel/tigerlake/spd... File src/soc/intel/tigerlake/spd/ddr4-empty-spd.hex:
PS8:
Why is this file rename a part of this change? It is not related anymore.
I think it's getting confused because I renamed it in a previous patchset and then renamed it back. Can we just leave it alone, or do I need to dig into git and figure out how to drop it from the patchset?
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/8/src/soc/intel/tigerlake/spd... File src/soc/intel/tigerlake/spd/ddr4-empty-spd.hex:
PS8:
I think it's getting confused because I renamed it in a previous patchset and then renamed it back. […]
Old name was ddr4-spd-empty.hex, current patchset name is ddr4-empty-spd.hex
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/8/src/soc/intel/tigerlake/spd... File src/soc/intel/tigerlake/spd/ddr4-empty-spd.hex:
PS8:
Old name was ddr4-spd-empty.hex, current patchset name is ddr4-empty-spd. […]
You're right, thank you for spotting the problem.
Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Angel Pons, Nick Vaccaro, Patrick Rudolph, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45746
to look at the new patch set (#9).
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
Add an empty SPD for LPDDR4x for waddledee and waddledoo to use.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 --- A src/soc/intel/jasperlake/spd/placeholder.spd.hex A src/soc/intel/tigerlake/spd/placeholder.spd.hex M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 12 files changed, 101 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/45746/9
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 9: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 9: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45746/9//COMMIT_MSG@17 PS9, Line 17: LPDDR4x nit: not LPDDR4x anymore? now we have a placeholder
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 9: Code-Review+2
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45746/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45746/9//COMMIT_MSG@17 PS9, Line 17: LPDDR4x
nit: not LPDDR4x anymore? now we have a placeholder
Ack
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45746 )
Change subject: templates: add an empty SPD to SPD_SOURCES ......................................................................
templates: add an empty SPD to SPD_SOURCES
Add an empty SPD in SPD_SOURCES when creating a new variant of hatch, volteer, waddledee, or waddledoo, so that coreboot can build successfully.
For variants that use spd_tools, add an empty mem_parts_used.txt so that the developer can add the supported memory parts and regenerate the Makefile.inc with the correct SPD references.
Add an empty SPD for LPDDR4x for waddledee and waddledoo to use.
BUG=b:169422833 TEST=create a new variant of hatch, volteer, waddledee, and waddledoo. Observe that each one succeeds.
Signed-off-by: Paul Fagerburg pfagerburg@google.com Change-Id: I06dfb6103701bf8949180595f1e98fac48bcc585 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45746 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nick Vaccaro nvaccaro@google.com --- A src/soc/intel/jasperlake/spd/placeholder.spd.hex A src/soc/intel/tigerlake/spd/placeholder.spd.hex M util/mainboard/google/hatch/template/Makefile.inc A util/mainboard/google/volteer/template/memory/Makefile.inc A util/mainboard/google/volteer/template/memory/dram_id.generated.txt A util/mainboard/google/volteer/template/memory/mem_parts_used.txt A util/mainboard/google/waddledee/template/memory/Makefile.inc A util/mainboard/google/waddledee/template/memory/dram_id.generated.txt A util/mainboard/google/waddledee/template/memory/mem_parts_used.txt A util/mainboard/google/waddledoo/template/memory/Makefile.inc A util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt A util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt 12 files changed, 101 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Nick Vaccaro: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/jasperlake/spd/placeholder.spd.hex b/src/soc/intel/jasperlake/spd/placeholder.spd.hex new file mode 100644 index 0000000..67b46cd --- /dev/null +++ b/src/soc/intel/jasperlake/spd/placeholder.spd.hex @@ -0,0 +1,32 @@ +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 80 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/soc/intel/tigerlake/spd/placeholder.spd.hex b/src/soc/intel/tigerlake/spd/placeholder.spd.hex new file mode 100644 index 0000000..1a5be53 --- /dev/null +++ b/src/soc/intel/tigerlake/spd/placeholder.spd.hex @@ -0,0 +1,32 @@ +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/util/mainboard/google/hatch/template/Makefile.inc b/util/mainboard/google/hatch/template/Makefile.inc index 61b23ed..599cfcc 100644 --- a/util/mainboard/google/hatch/template/Makefile.inc +++ b/util/mainboard/google/hatch/template/Makefile.inc @@ -1,4 +1,6 @@ ## ## SPDX-License-Identifier: GPL-2.0-only
-SPD_SOURCES = +## TODO engineer creating a new variant needs to add SPDs for memory parts + +SPD_SOURCES = empty_ddr4 diff --git a/util/mainboard/google/volteer/template/memory/Makefile.inc b/util/mainboard/google/volteer/template/memory/Makefile.inc new file mode 100644 index 0000000..b0ca222 --- /dev/null +++ b/util/mainboard/google/volteer/template/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder.spd.hex diff --git a/util/mainboard/google/volteer/template/memory/dram_id.generated.txt b/util/mainboard/google/volteer/template/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/volteer/template/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/volteer/template/memory/mem_parts_used.txt b/util/mainboard/google/volteer/template/memory/mem_parts_used.txt new file mode 100644 index 0000000..f51b3af --- /dev/null +++ b/util/mainboard/google/volteer/template/memory/mem_parts_used.txt @@ -0,0 +1,4 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4 or util/spd_tools/lp4x +# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. diff --git a/util/mainboard/google/waddledee/template/memory/Makefile.inc b/util/mainboard/google/waddledee/template/memory/Makefile.inc new file mode 100644 index 0000000..b0ca222 --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder.spd.hex diff --git a/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt b/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt b/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt new file mode 100644 index 0000000..59381dc --- /dev/null +++ b/util/mainboard/google/waddledee/template/memory/mem_parts_used.txt @@ -0,0 +1,6 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/lp4x +# See util/spd_tools/lp4x/README.md for more details and instructions. + +# Part Name diff --git a/util/mainboard/google/waddledoo/template/memory/Makefile.inc b/util/mainboard/google/waddledoo/template/memory/Makefile.inc new file mode 100644 index 0000000..b0ca222 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder.spd.hex diff --git a/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt b/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt b/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt new file mode 100644 index 0000000..59381dc --- /dev/null +++ b/util/mainboard/google/waddledoo/template/memory/mem_parts_used.txt @@ -0,0 +1,6 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/lp4x +# See util/spd_tools/lp4x/README.md for more details and instructions. + +# Part Name
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)