Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56794 )
Change subject: libpayload/pci: Add PCIe interfaces for MediaTek platform ......................................................................
Patch Set 7:
(4 comments)
File payloads/libpayload/Kconfig:
https://review.coreboot.org/c/coreboot/+/56794/comment/fb01d84e_e62d5a95 PS3, Line 408: in
on
Done
https://review.coreboot.org/c/coreboot/+/56794/comment/70193082_7b6fc672 PS3, Line 408: PCI
PCI or PCIE? […]
Use PCIe instead, thanks.
File payloads/libpayload/drivers/pcie_mediatek.c:
https://review.coreboot.org/c/coreboot/+/56794/comment/71a62403_c92dd1da PS3, Line 50: ((1 << (size * 8)) - 1)
This mask shouldn't be necessary, as the return type of the `pci_read_configX()` functions already t […]
Done, use pci_map_bus() instead, thanks.
File payloads/libpayload/include/pci.h:
https://review.coreboot.org/c/coreboot/+/56794/comment/13f8887f_343ca316 PS3, Line 116: void pci_update_hw_base(uintptr_t base);
Please extend the commit message, why this is useful to have, or add a comment here.
Added introduction to commit message, thanks.
-
Jianjun Wang (Code Review)