Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38153 )
Change subject: device/smbus: Drop SMBUS_HAS_AUX_CHANNELS ......................................................................
device/smbus: Drop SMBUS_HAS_AUX_CHANNELS
The guarded prototypes are no longer implemented in the tree.
Change-Id: I5bfedde2aaf691826e7537eceb8578a855800ea2 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/device/Kconfig M src/include/device/smbus.h 2 files changed, 0 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/38153/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index 9ae3bbd..f694c14 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -477,10 +477,6 @@
endmenu # "Display"
-config SMBUS_HAS_AUX_CHANNELS - bool - default n - config PCI bool default n diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h index 863bc80..094ad42 100644 --- a/src/include/device/smbus.h +++ b/src/include/device/smbus.h @@ -53,9 +53,4 @@ int smbus_block_read(struct device *dev, u8 cmd, u8 bytes, u8 *buffer); int smbus_block_write(struct device *dev, u8 cmd, u8 bytes, const u8 *buffer);
-#if CONFIG(SMBUS_HAS_AUX_CHANNELS) -void smbus_switch_to_channel(uint8_t channel_number); -uint8_t smbus_get_current_channel(void); -#endif - #endif /* DEVICE_SMBUS_H */
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38153 )
Change subject: device/smbus: Drop SMBUS_HAS_AUX_CHANNELS ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38153 )
Change subject: device/smbus: Drop SMBUS_HAS_AUX_CHANNELS ......................................................................
Patch Set 1: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38153 )
Change subject: device/smbus: Drop SMBUS_HAS_AUX_CHANNELS ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38153 )
Change subject: device/smbus: Drop SMBUS_HAS_AUX_CHANNELS ......................................................................
device/smbus: Drop SMBUS_HAS_AUX_CHANNELS
The guarded prototypes are no longer implemented in the tree.
Change-Id: I5bfedde2aaf691826e7537eceb8578a855800ea2 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38153 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M src/device/Kconfig M src/include/device/smbus.h 2 files changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Frans Hendriks: Looks good to me, but someone else must approve
diff --git a/src/device/Kconfig b/src/device/Kconfig index f7adb07..0bd9fe1 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -480,10 +480,6 @@
endmenu # "Display"
-config SMBUS_HAS_AUX_CHANNELS - bool - default n - config PCI bool default n diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h index 863bc80..094ad42 100644 --- a/src/include/device/smbus.h +++ b/src/include/device/smbus.h @@ -53,9 +53,4 @@ int smbus_block_read(struct device *dev, u8 cmd, u8 bytes, u8 *buffer); int smbus_block_write(struct device *dev, u8 cmd, u8 bytes, const u8 *buffer);
-#if CONFIG(SMBUS_HAS_AUX_CHANNELS) -void smbus_switch_to_channel(uint8_t channel_number); -uint8_t smbus_get_current_channel(void); -#endif - #endif /* DEVICE_SMBUS_H */
-
Frans Hendriks (Code Review) -
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)