Attention is currently required from: Fabio Aiuto, Paul Menzel, Tim Wawrzynczak, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68101 )
Change subject: include/device/device_util.c: add helpers to check pci device enabled ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68101/comment/9b0b41d2_c0595a63 PS1, Line 7: add helpers to check pci device enabled Hmmm, this is a bit confusing, how about:
Add predicates for PCI devices
Where "predicate" is a function that returns true or false (the equivalent of a "yes/no question" in human communication languages).
File src/device/device_util.c:
https://review.coreboot.org/c/coreboot/+/68101/comment/17dac690_85b2a122 PS1, Line 969: pci These names are somewhat inaccurate, as this could be a non-PCI device. Would be nice to rename them to `dev`, although the `cpu` names above should also be changed.
This can be done in a follow-up.