Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35403 )
Change subject: soc/intel/common/basecode: Implement CSE update flow
......................................................................
Patch Set 95:
(4 comments)
Thank you for writing the documentation.
https://review.coreboot.org/c/coreboot/+/35403/95//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35403/95//COMMIT_MSG@9
PS95, Line 9: have been
Nit: Present tense: are
https://review.coreboot.org/c/coreboot/+/35403/95//COMMIT_MSG@13
PS95, Line 13: version
versions
https://review.coreboot.org/c/coreboot/+/35403/95//COMMIT_MSG@15
PS95, Line 15: * Set the CSE's next boot partition to RO using SET_BOOT_PARTITION
: HECI command.
: * Send global reset command to reset the system.
In the commit message (and comments), please use spaces for indenting the items, and align the wrapped around item to the first word of the first item line.
https://review.coreboot.org/c/coreboot/+/35403/95/Documentation/soc/intel/cs...
File Documentation/soc/intel/cse_fw_update/cse_fw_update.md:
https://review.coreboot.org/c/coreboot/+/35403/95/Documentation/soc/intel/cs...
PS95, Line 11: ChromiumOS Systems
Chromium OS systems
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35403
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12f6bba3324069d65edabaccd234006b0840e700
Gerrit-Change-Number: 35403
Gerrit-PatchSet: 95
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 05:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment