Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Elyes Haouas, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Paul Menzel, Zheng Bao, Elyes Haouas, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62750
to look at the new patch set (#2).
Change subject: $(TOP)/Makefile.inc: Handle the folder common before specific one ......................................................................
$(TOP)/Makefile.inc: Handle the folder common before specific one
Put src/soc/*/common before src/soc/*/*, just like src/superio/common is before src/superio/*, can make the variables in common Makefile get the expected value before they are used in other subdirs.
The duplicated "common" in the result string can be eliminated finally.
Then e can put some common variables in all the subdir Makefile.inc to the common Makefile.inc to reduce code redundancy.
Change-Id: I99597af22cac6d12aaef348789664cd7db02ba06 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/62750/2