Attention is currently required from: Rex-BC Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56106 )
Change subject: vc/mediatek/mt8195: Enable DRAM Vcore DVFS settings
......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/mediatek/mt8195/dramc/dramc_top.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/184c56a8_528dad71
PS3, Line 355: #elif CONFIG(CHROMEOS)
Done
Sorry, comparing with the dram-k blob implementation I want to have something that can be shared between both (also make it possible so you can backport to ETT):
What about
1. in vendorcode/mediatek/Makefile.inc add
CPPFLAGS_common += -D FOR_COREBOOT
2. Change your implementations to
#elif defined(FOR_COREBOOT)
return ...
#else
return 0
#endif
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56106
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39342aea902a87cdc2c5b862e5d1a889fcc822c5
Gerrit-Change-Number: 56106
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Ryan Chuang
ryan.chuang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Jul 2021 02:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Rex-BC Chen
rex-bc.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment