Attention is currently required from: Sean Rhodes, Benjamin Doron, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/option/cfr.h:
https://review.coreboot.org/c/coreboot/+/74121/comment/bf6868e8_16b8e0c6
PS3, Line 133: /* CFR_OPT_NAME opt_name */
: /* CFR_UI_NAME ui_name */
: /* CFR_UI_HELPTEXT ui_helptext (Optional) */
:
Yes, will fix.
Done
File src/drivers/option/cfr.c:
https://review.coreboot.org/c/coreboot/+/74121/comment/2878c079_5339a3fb
PS3, Line 103: option->option_id = option_id;
: option->flags = flags;
: option->default_value = default_value;
: option->size = sizeof(*option);
:
: current += option->size;
: current += sm_write_opt_name(current, opt_name)
`opt` and `option` - should be the same
You mean the naming of `option_id` and `opt_name` is inconsistent? Renamed the former to `object_id` as it can also be used for non-option stuff (forms, text).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski
info@orangecms.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 03 May 2023 11:14:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Benjamin Doron
benjamin.doron00@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment