Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86070?usp=email )
Change subject: soc/mediatek/mt8196: Add vcore DVFS settings
......................................................................
Patch Set 3:
(2 comments)
File src/soc/mediatek/mt8196/include/soc/mtk_vcore_opp.h:
https://review.coreboot.org/c/coreboot/+/86070/comment/34e3b620_a1ef575f?usp... :
PS1, Line 9: extern
remove
Done
File src/soc/mediatek/mt8196/mtk_vcore_opp.c:
PS1:
Drop `mtk_` from the file name. Does it make sense to rename this to `dvfsrc. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0d3e1d6ea648af938d41a5c9461cdd2972371177
Gerrit-Change-Number: 86070
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 21 Jan 2025 10:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com