Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/28724 )
Change subject: commonlib/region: Add region protect API ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/28724/2/src/commonlib/include/commonlib/regi... File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/#/c/28724/2/src/commonlib/include/commonlib/regi... PS2, Line 67: * Write protect the region indicated by region device.
copy paste error ?
Done
https://review.coreboot.org/#/c/28724/1/src/commonlib/include/commonlib/regi... File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/#/c/28724/1/src/commonlib/include/commonlib/regi... PS1, Line 67: Write protect the region indicated by region device.
use enum cb_err with CB_SUCCESS and CB_ERR.
Was keeping it in-line with rest of the APIs in this file.
https://review.coreboot.org/#/c/28724/2/src/commonlib/region.c File src/commonlib/region.c:
https://review.coreboot.org/#/c/28724/2/src/commonlib/region.c@154 PS2, Line 154: /* Write protect the region indicated by region device */
please mention in a comment that it'll make the flash write protected
Done
-
Rizwan Qureshi (Code Review)