Change in coreboot[master]: security/vboot: Add VB2_LIB to postcar stage if available - coreboot-gerrit

6 Nov 2018


      Werner Zeh has posted comments on this change. ( https://review.coreboot.org/29465 )
Change subject: security/vboot: Add VB2_LIB to postcar stage if available
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29465/1/src/security/vboot/Makefile.inc
File src/security/vboot/Makefile.inc:
https://review.coreboot.org/#/c/29465/1/src/security/vboot/Makefile.inc@115
PS1, Line 115: ifeq ($(CONFIG_POSTCAR_STAGE), y)
...
I don't think you need to guard this, actually. […]
Well, I was adviced to do so by Patrick.
But at the second glance you seem to be right. This just adds the VB2_LIB to the sources of the postcar. Should be OK to do it unconditionally.
@Patrick: Have we overseen something?
-- 
To view, visit https://review.coreboot.org/29465
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I933d33b0188d1b123bb4735722b6086e7786624f
Gerrit-Change-Number: 29465
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Tue, 06 Nov 2018 08:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No