Change in coreboot[master]: mb/51nb/x210: correct battery ACPI

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Matt DeVillier (Code Review)

26 Feb 2020 26 Feb '20

8:14 p.m.

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

mb/51nb/x210: correct battery ACPI

Derived from x210_test branch of HarryKipper's repo: https://github.com/harrykipper/coreboot

Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/51nb/x210/acpi/battery.asl 1 file changed, 4 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/39142/1

diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index 9a3a361..6689c83 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -50,16 +50,16 @@ Method (_BIF, 0, Serialized) { /* Design Capacity */ - Store (DGCP, Index (PBIF, 1)) + Store (DGCP * 10000 / DGVO, Index (PBIF, 1))

/* Last Full Charge Capacity */ - Store (FLCP, Index (PBIF, 2)) + Store (FLCP * 10000 / DGVO, Index (PBIF, 2))

/* Design Voltage */ Store (DGVO, Index (PBIF, 4))

/* Design Capacity of Warning */ - Store (BDW, Index (PBIF, 5)) + Store (BDW * 10000 / DGVO, Index (PBIF, 5))

/* Design Capacity of Low */ Store (BDL, Index (PBIF, 6)) @@ -93,7 +93,7 @@ /* * 2: BATTERY REMAINING CAPACITY */ - Store (BRC, Index (PBST, 2)) + Store (BRC * 10000 / DGVO, Index (PBST, 2))

/* * 3: BATTERY PRESENT VOLTAGE

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Matt DeVillier (Code Review)

26 Feb 26 Feb

9:04 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 4:

This change is ready for review.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Feb 2020 20:04:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

11:02 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 4: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/39142/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39142/4//COMMIT_MSG@9 PS4, Line 9: Derived from x210_test branch of HarryKipper's repo: Maybe mention the specific issue:

https://github.com/harrykipper/coreboot/commit/2f68f138adb25605e5715896636cf...

https://github.com/torvalds/linux/blob/master/drivers/acpi/battery.c#L93

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Feb 2020 22:02:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

11:14 p.m.

Hello Angel Pons, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39142

to look at the new patch set (#5).

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

mb/51nb/x210: correct battery ACPI

The X210 EC reports battery values in broken mAh. These have to be adjusted by 10000 * DGVO, as documented in https://github.com/torvalds/linux/blob/master/drivers/acpi/battery.c.

Taken from https://github.com/harrykipper/coreboot, commits 2f68f138adb25605e5715896636cf33f6de5bd95 c1c72cc43708a6647f263a767c39cf3072908e20

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/39142/5

Matt DeVillier (Code Review)

11:15 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39142/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/39142/4//COMMIT_MSG@9 PS4, Line 9: Derived from x210_test branch of HarryKipper's repo:

...

Maybe mention the specific issue: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 5 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 26 Feb 2020 22:15:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4 Mar 4 Mar

4:37 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 04 Mar 2020 15:37:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

14 Mar 14 Mar

9:16 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 6: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 14 Mar 2020 20:16:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

15 Mar 15 Mar

1:53 a.m.

Hello build bot (Jenkins), Patrick Georgi, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39142

to look at the new patch set (#7).

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

mb/51nb/x210: correct battery ACPI

The X210 EC reports battery values in broken mAh. These have to be adjusted by 10000 * DGVO, as documented in https://github.com/torvalds/linux/blob/master/drivers/acpi/battery.c.

Taken from https://github.com/harrykipper/coreboot, commits 2f68f138adb25605e5715896636cf33f6de5bd95 c1c72cc43708a6647f263a767c39cf3072908e20

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/39142/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 7 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

2 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 7 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 15 Mar 2020 01:00:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

16 Mar 16 Mar

3:42 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

Patch Set 8: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 8 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 16 Mar 2020 14:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

3:42 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39142 )

Change subject: mb/51nb/x210: correct battery ACPI ......................................................................

mb/51nb/x210: correct battery ACPI

The X210 EC reports battery values in broken mAh. These have to be adjusted by 10000 * DGVO, as documented in https://github.com/torvalds/linux/blob/master/drivers/acpi/battery.c.

Taken from https://github.com/harrykipper/coreboot, commits 2f68f138adb25605e5715896636cf33f6de5bd95 c1c72cc43708a6647f263a767c39cf3072908e20

Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39142 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/51nb/x210/acpi/battery.asl 1 file changed, 4 insertions(+), 4 deletions(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/51nb/x210/acpi/battery.asl b/src/mainboard/51nb/x210/acpi/battery.asl index 9064ad5..25a2b01 100644 --- a/src/mainboard/51nb/x210/acpi/battery.asl +++ b/src/mainboard/51nb/x210/acpi/battery.asl @@ -38,16 +38,16 @@ Method (_BIF, 0, Serialized) { /* Design Capacity */ - Store (DGCP, Index (PBIF, 1)) + Store (DGCP * 10000 / DGVO, Index (PBIF, 1))

/* Last Full Charge Capacity */ - Store (FLCP, Index (PBIF, 2)) + Store (FLCP * 10000 / DGVO, Index (PBIF, 2))

/* Design Voltage */ Store (DGVO, Index (PBIF, 4))

/* Design Capacity of Warning */ - Store (BDW, Index (PBIF, 5)) + Store (BDW * 10000 / DGVO, Index (PBIF, 5))

/* Design Capacity of Low */ Store (BDL, Index (PBIF, 6)) @@ -81,7 +81,7 @@ /* * 2: BATTERY REMAINING CAPACITY */ - Store (BRC, Index (PBST, 2)) + Store (BRC * 10000 / DGVO, Index (PBST, 2))

/* * 3: BATTERY PRESENT VOLTAGE

-- To view, visit https://review.coreboot.org/c/coreboot/+/39142 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie097272443b18b16c3937034f874d3b5a6bdd62a Gerrit-Change-Number: 39142 Gerrit-PatchSet: 9 Gerrit-Owner: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1713

days inactive

1732

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
Felix Held (Code Review)
Matt DeVillier (Code Review)
Patrick Georgi (Code Review)