Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72747 )
Change subject: soc/mediatek: Add support for regulator VM18
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
src/mainboard/google/corsola/regulator.c:27:1: error: static assertion failed: "regulator_id size error"
27 | _Static_assert(ARRAY_SIZE(regulator_id) == MTK_REGULATOR_NUM, "regulator_id size error");
| ^~~~~~~~~~~~~~
cc1: note: unrecognized command-line option '-Wno-array-compare' may have been intended to silence earlier diagnostics
make[2]: *** [Makefile:399: /cb-build/coreboot-gerrit.0/gcc-chromeos/GOOGLE_KINGLER/romstage/mainboard/google/corsola/regulator.o] Error 1
make[2]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit'
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8c3b2df1157b23b37492b1e9b1716903ea67799
Gerrit-Change-Number: 72747
Gerrit-PatchSet: 2
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 06 Feb 2023 03:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment