Change in ...coreboot[master]: ec/google/wilco: Send "logo displayed" progress code

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32348

Change subject: ec/google/wilco: Send "logo displayed" progress code
......................................................................

ec/google/wilco: Send "logo displayed" progress code

This progress code enables keyboard backlight control that
otherwise would only work 30 seconds after boot.  This code
is already defined but it was not being sent by coreboot.
It is run in the "post device" step between the other defined
progress codes.

BUG=b:130754032

Change-Id: Ica6c622e568cb236c17bf3edb6639d0177510846
Signed-off-by: Duncan Laurie 
---
M src/ec/google/wilco/chip.c
1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/32348/1

diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c
index 0858e1c..9b0be19 100644
--- a/src/ec/google/wilco/chip.c
+++ b/src/ec/google/wilco/chip.c
@@ -46,6 +46,13 @@
 BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT,
    	      wilco_ec_post_video_init, NULL);

+static void wilco_ec_post_logo_displayed(void *unused)
+{
+	wilco_ec_send(KB_BIOS_PROGRESS, BIOS_PROGRESS_LOGO_DISPLAYED);
+}
+BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT,
+		      wilco_ec_post_logo_displayed, NULL);
+
 static void wilco_ec_resume(void *unused)
 {
    wilco_ec_send_noargs(KB_RESTORE);

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32348 )

Change subject: ec/google/wilco: Send "logo displayed" progress code
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32348 )

Change subject: ec/google/wilco: Send "logo displayed" progress code
......................................................................

Patch Set 1: Code-Review+1

[Duncan Laurie (Code Review)]

Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32348 )

Change subject: ec/google/wilco: Send "logo displayed" progress code
......................................................................

ec/google/wilco: Send "logo displayed" progress code

This progress code enables keyboard backlight control that
otherwise would only work 30 seconds after boot.  This code
is already defined but it was not being sent by coreboot.
It is run in the "post device" step between the other defined
progress codes.

BUG=b:130754032

Change-Id: Ica6c622e568cb236c17bf3edb6639d0177510846
Signed-off-by: Duncan Laurie 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32348
Tested-by: build bot (Jenkins) 
Reviewed-by: Lijian Zhao 
Reviewed-by: Paul Menzel 
---
M src/ec/google/wilco/chip.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Lijian Zhao: Looks good to me, approved

diff --git a/src/ec/google/wilco/chip.c b/src/ec/google/wilco/chip.c
index 0858e1c..9b0be19 100644
--- a/src/ec/google/wilco/chip.c
+++ b/src/ec/google/wilco/chip.c
@@ -46,6 +46,13 @@
 BOOT_STATE_INIT_ENTRY(BS_DEV_INIT, BS_ON_EXIT,
    	      wilco_ec_post_video_init, NULL);

+static void wilco_ec_post_logo_displayed(void *unused)
+{
+	wilco_ec_send(KB_BIOS_PROGRESS, BIOS_PROGRESS_LOGO_DISPLAYED);
+}
+BOOT_STATE_INIT_ENTRY(BS_POST_DEVICE, BS_ON_EXIT,
+		      wilco_ec_post_logo_displayed, NULL);
+
 static void wilco_ec_resume(void *unused)
 {
    wilco_ec_send_noargs(KB_RESTORE);