HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44288 )
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
sb/intel/lynxpoint/smihandler.c: Remove dead assignment
Change-Id: Icaae8a986cd375e2b67f05883688847e1a174082 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/lynxpoint/smihandler.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/44288/1
diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index e4ebffd..bb05f99 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -427,7 +427,7 @@ { #define IOTRAP(x) (trap_sts & (1 << x)) u32 trap_sts, trap_cycle; - u32 data, mask = 0; + u32 mask = 0; int i;
trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register @@ -454,8 +454,9 @@ if (IOTRAP(0)) { if (!(trap_cycle & (1 << 24))) { // It's a write printk(BIOS_DEBUG, "SMI1 command\n"); - data = RCBA32(0x1e18); - data &= mask; + (void)RCBA32(0x1e18); + // data = RCBA32(0x1e18); + // data &= mask; // if (smi1) // southbridge_smi_command(data); // return; @@ -474,8 +475,7 @@
if (!(trap_cycle & (1 << 24))) { /* Write Cycle */ - data = RCBA32(0x1e18); - printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); + printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", RCBA32(0x1e18)); } #undef IOTRAP }
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44288 )
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44288/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/44288/1/src/southbridge/intel/lynxp... PS1, Line 478: printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", RCBA32(0x1e18)); uh, that's unrelated?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44288 )
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44288/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/44288/1/src/southbridge/intel/lynxp... PS1, Line 478: printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", RCBA32(0x1e18));
uh, that's unrelated?
"data" is not used.
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44288
to look at the new patch set (#2).
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
sb/intel/lynxpoint/smihandler.c: Remove dead assignment
Also remove unused 'data'.
Change-Id: Icaae8a986cd375e2b67f05883688847e1a174082 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/southbridge/intel/lynxpoint/smihandler.c 1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/44288/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44288 )
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44288/1/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/smihandler.c:
https://review.coreboot.org/c/coreboot/+/44288/1/src/southbridge/intel/lynxp... PS1, Line 478: printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", RCBA32(0x1e18));
"data" is not used.
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44288 )
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44288/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44288/2//COMMIT_MSG@9 PS2, Line 9: unused I'd use `unnecessary`. The variable is used, but it's not necessary.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44288 )
Change subject: sb/intel/lynxpoint/smihandler.c: Remove dead assignment ......................................................................
sb/intel/lynxpoint/smihandler.c: Remove dead assignment
Also remove unused 'data'.
Change-Id: Icaae8a986cd375e2b67f05883688847e1a174082 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/44288 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/southbridge/intel/lynxpoint/smihandler.c 1 file changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/southbridge/intel/lynxpoint/smihandler.c b/src/southbridge/intel/lynxpoint/smihandler.c index e4ebffd..bb05f99 100644 --- a/src/southbridge/intel/lynxpoint/smihandler.c +++ b/src/southbridge/intel/lynxpoint/smihandler.c @@ -427,7 +427,7 @@ { #define IOTRAP(x) (trap_sts & (1 << x)) u32 trap_sts, trap_cycle; - u32 data, mask = 0; + u32 mask = 0; int i;
trap_sts = RCBA32(0x1e00); // TRSR - Trap Status Register @@ -454,8 +454,9 @@ if (IOTRAP(0)) { if (!(trap_cycle & (1 << 24))) { // It's a write printk(BIOS_DEBUG, "SMI1 command\n"); - data = RCBA32(0x1e18); - data &= mask; + (void)RCBA32(0x1e18); + // data = RCBA32(0x1e18); + // data &= mask; // if (smi1) // southbridge_smi_command(data); // return; @@ -474,8 +475,7 @@
if (!(trap_cycle & (1 << 24))) { /* Write Cycle */ - data = RCBA32(0x1e18); - printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", data); + printk(BIOS_DEBUG, " iotrap written data = 0x%08x\n", RCBA32(0x1e18)); } #undef IOTRAP }
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)