Change in coreboot[master]: mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40863 )

Change subject: mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE
......................................................................

mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE

It is only used with the Lenovo-specific H8 EC code.

Change-Id: I596d4d19277555894ab728e32a44e34a5a21e21d
Signed-off-by: Angel Pons 
---
M src/mainboard/apple/macbook21/dsdt.asl
M src/mainboard/apple/macbookair4_2/dsdt.asl
M src/mainboard/asrock/b75pro3-m/dsdt.asl
M src/mainboard/asus/p8h61-m_pro/dsdt.asl
M src/mainboard/asus/p8z77-m_pro/dsdt.asl
M src/mainboard/compulab/intense_pc/dsdt.asl
M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
M src/mainboard/hp/snb_ivb_laptops/dsdt.asl
M src/mainboard/hp/z220_sff_workstation/dsdt.asl
M src/mainboard/sapphire/pureplatinumh61/dsdt.asl
11 files changed, 7 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/40863/1

diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl
index f14272d..db0ae47 100644
--- a/src/mainboard/apple/macbook21/dsdt.asl
+++ b/src/mainboard/apple/macbook21/dsdt.asl
@@ -3,7 +3,6 @@

#define BRIGHTNESS_UP \DSPC.BRTU
 #define BRIGHTNESS_DOWN \DSPC.BRTD
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0

#include <arch/acpi.h>
 DefinitionBlock(
diff --git a/src/mainboard/apple/macbookair4_2/dsdt.asl b/src/mainboard/apple/macbookair4_2/dsdt.asl
index 01656ad..b173dbe 100644
--- a/src/mainboard/apple/macbookair4_2/dsdt.asl
+++ b/src/mainboard/apple/macbookair4_2/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/asrock/b75pro3-m/dsdt.asl b/src/mainboard/asrock/b75pro3-m/dsdt.asl
index ff5c708..1b52040 100644
--- a/src/mainboard/asrock/b75pro3-m/dsdt.asl
+++ b/src/mainboard/asrock/b75pro3-m/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/asus/p8h61-m_pro/dsdt.asl b/src/mainboard/asus/p8h61-m_pro/dsdt.asl
index 7da32d3..40bb732 100644
--- a/src/mainboard/asus/p8h61-m_pro/dsdt.asl
+++ b/src/mainboard/asus/p8h61-m_pro/dsdt.asl
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl
index 0c02456..591473a 100644
--- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl
+++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl
@@ -1,8 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
-
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/compulab/intense_pc/dsdt.asl b/src/mainboard/compulab/intense_pc/dsdt.asl
index 247114e..9d4c890 100644
--- a/src/mainboard/compulab/intense_pc/dsdt.asl
+++ b/src/mainboard/compulab/intense_pc/dsdt.asl
@@ -4,7 +4,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl b/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
index cea8efe..890956e 100644
--- a/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
+++ b/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
@@ -1,8 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
-
 #include <arch/acpi.h>

DefinitionBlock(
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
index 150bdcf..27329e4 100644
--- a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
+++ b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/hp/snb_ivb_laptops/dsdt.asl b/src/mainboard/hp/snb_ivb_laptops/dsdt.asl
index 150bdcf..27329e4 100644
--- a/src/mainboard/hp/snb_ivb_laptops/dsdt.asl
+++ b/src/mainboard/hp/snb_ivb_laptops/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/hp/z220_sff_workstation/dsdt.asl b/src/mainboard/hp/z220_sff_workstation/dsdt.asl
index 150bdcf..27329e4 100644
--- a/src/mainboard/hp/z220_sff_workstation/dsdt.asl
+++ b/src/mainboard/hp/z220_sff_workstation/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl
index 8b23ee7..7cf6e08 100644
--- a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl
+++ b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl
@@ -15,7 +15,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <arch/acpi.h>
 DefinitionBlock(
    "dsdt.aml",

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Evgeny Zinoviev,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/40863

to look at the new patch set (#2).

Change subject: mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE
......................................................................

mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE

It is only used with the Lenovo-specific H8 EC code.

Change-Id: I596d4d19277555894ab728e32a44e34a5a21e21d
Signed-off-by: Angel Pons 
---
M src/mainboard/apple/macbook21/dsdt.asl
M src/mainboard/apple/macbookair4_2/dsdt.asl
M src/mainboard/asrock/b75pro3-m/dsdt.asl
M src/mainboard/asus/p8h61-m_pro/dsdt.asl
M src/mainboard/asus/p8z77-m_pro/dsdt.asl
M src/mainboard/compulab/intense_pc/dsdt.asl
M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
M src/mainboard/hp/snb_ivb_laptops/dsdt.asl
M src/mainboard/hp/z220_sff_workstation/dsdt.asl
M src/mainboard/sapphire/pureplatinumh61/dsdt.asl
11 files changed, 7 insertions(+), 13 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/40863/2

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40863 )

Change subject: mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40863 )

Change subject: mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE
......................................................................

mb/**/dsdt.asl: Drop unused ACPI_VIDEO_DEVICE

It is only used with the Lenovo-specific H8 EC code.

Change-Id: I596d4d19277555894ab728e32a44e34a5a21e21d
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40863
Tested-by: build bot (Jenkins) 
Reviewed-by: HAOUAS Elyes 
---
M src/mainboard/apple/macbook21/dsdt.asl
M src/mainboard/apple/macbookair4_2/dsdt.asl
M src/mainboard/asrock/b75pro3-m/dsdt.asl
M src/mainboard/asus/p8h61-m_pro/dsdt.asl
M src/mainboard/asus/p8z77-m_pro/dsdt.asl
M src/mainboard/compulab/intense_pc/dsdt.asl
M src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
M src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
M src/mainboard/hp/snb_ivb_laptops/dsdt.asl
M src/mainboard/hp/z220_sff_workstation/dsdt.asl
M src/mainboard/sapphire/pureplatinumh61/dsdt.asl
11 files changed, 7 insertions(+), 13 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved

diff --git a/src/mainboard/apple/macbook21/dsdt.asl b/src/mainboard/apple/macbook21/dsdt.asl
index 77d6daf..eabb7a2 100644
--- a/src/mainboard/apple/macbook21/dsdt.asl
+++ b/src/mainboard/apple/macbook21/dsdt.asl
@@ -3,7 +3,6 @@

#define BRIGHTNESS_UP \DSPC.BRTU
 #define BRIGHTNESS_DOWN \DSPC.BRTD
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0

#include <acpi/acpi.h>
 DefinitionBlock(
diff --git a/src/mainboard/apple/macbookair4_2/dsdt.asl b/src/mainboard/apple/macbookair4_2/dsdt.asl
index 315fd4d..7913816 100644
--- a/src/mainboard/apple/macbookair4_2/dsdt.asl
+++ b/src/mainboard/apple/macbookair4_2/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/asrock/b75pro3-m/dsdt.asl b/src/mainboard/asrock/b75pro3-m/dsdt.asl
index 6d9866e..b83703c 100644
--- a/src/mainboard/asrock/b75pro3-m/dsdt.asl
+++ b/src/mainboard/asrock/b75pro3-m/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/asus/p8h61-m_pro/dsdt.asl b/src/mainboard/asus/p8h61-m_pro/dsdt.asl
index b77c2ba..66608b0 100644
--- a/src/mainboard/asus/p8h61-m_pro/dsdt.asl
+++ b/src/mainboard/asus/p8h61-m_pro/dsdt.asl
@@ -1,7 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/asus/p8z77-m_pro/dsdt.asl b/src/mainboard/asus/p8z77-m_pro/dsdt.asl
index ce1d905..21b3954 100644
--- a/src/mainboard/asus/p8z77-m_pro/dsdt.asl
+++ b/src/mainboard/asus/p8z77-m_pro/dsdt.asl
@@ -1,8 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
-
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/compulab/intense_pc/dsdt.asl b/src/mainboard/compulab/intense_pc/dsdt.asl
index f6d5d4a..947e053 100644
--- a/src/mainboard/compulab/intense_pc/dsdt.asl
+++ b/src/mainboard/compulab/intense_pc/dsdt.asl
@@ -4,7 +4,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl b/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
index 1b7bf22..ce93c59 100644
--- a/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
+++ b/src/mainboard/gigabyte/ga-h61m-series/dsdt.asl
@@ -1,8 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0-only */
 /* This file is part of the coreboot project. */

-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
-
 #include <acpi/acpi.h>

DefinitionBlock(
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
index 5fc8201..f093207 100644
--- a/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
+++ b/src/mainboard/hp/compaq_8200_elite_sff/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/hp/snb_ivb_laptops/dsdt.asl b/src/mainboard/hp/snb_ivb_laptops/dsdt.asl
index 5fc8201..f093207 100644
--- a/src/mainboard/hp/snb_ivb_laptops/dsdt.asl
+++ b/src/mainboard/hp/snb_ivb_laptops/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/hp/z220_sff_workstation/dsdt.asl b/src/mainboard/hp/z220_sff_workstation/dsdt.asl
index 5fc8201..f093207 100644
--- a/src/mainboard/hp/z220_sff_workstation/dsdt.asl
+++ b/src/mainboard/hp/z220_sff_workstation/dsdt.asl
@@ -3,7 +3,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",
diff --git a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl
index 72204e0..0b75683 100644
--- a/src/mainboard/sapphire/pureplatinumh61/dsdt.asl
+++ b/src/mainboard/sapphire/pureplatinumh61/dsdt.asl
@@ -15,7 +15,7 @@

#define BRIGHTNESS_UP _SB.PCI0.GFX0.INCB
 #define BRIGHTNESS_DOWN _SB.PCI0.GFX0.DECB
-#define ACPI_VIDEO_DEVICE _SB.PCI0.GFX0
+
 #include <acpi/acpi.h>
 DefinitionBlock(
    "dsdt.aml",