Martin Roth has posted comments on this change. ( https://review.coreboot.org/27486 )
Change subject: mainboard/google/kahlee: Add mainboard resume function ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboar... File src/mainboard/google/kahlee/mainboard.c:
https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/mainboar... PS1, Line 193: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) Is this needed here or below?
https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/#/c/27486/1/src/mainboard/google/kahlee/variants... PS1, Line 33: #if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) Needed?
-
Martin Roth (Code Review)