Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/61211 )
Change subject: gma: Add `Tiger_Point` PCH ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/61211/comment/55800c00_a0394dbe PS1, Line 13: - TBT / Type-C
If they did it right /o\ there'd be nothing to do. It should be handled […]
I haven't seen a PD controller that does lane muxing... on the Clevo L140CU there are ANX7411 and ANX7440, where one of both is the PD controller and the other the mux/cross-point switch. However, that is CML, where a regular DP port is used. On Clevu L140MU there is a TI PD controller and Intels Type-C/TBT controller, which does *MAGIC*. The Type-C/TBT DisplayPorts will have to be added to libgfxinit as additional ports. That's what IntelGraphicsPEIM/Gop does at least.
Tim already started to work on that: https://github.com/twawrzynczak/libgfxinit/commit/c60e367bcd9941966a0375dc20...
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/61211/comment/95980fbc_1c6fa0bf PS1, Line 57: when Skylake => Cannon_Point);
This would have to be changed back later when the CPU parts for […]
ack, thanks
https://review.coreboot.org/c/libgfxinit/+/61211/comment/dc8e722c_ea36813a PS1, Line 168: Cannon_Point_On : <genbool> := Skylake_On and then PCH >= Cannon_Point;
This definitely shouldn't change. It's supposed to mean `[From] Cannon Point […]
ack, that wasn't intended... it was late
-
Michael Niewöhner (Code Review)