Attention is currently required from: Felix Singer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74244 )
Change subject: util/docker: Decouple coreboot-sdk from other projects ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2: The step you're removing this from is part of the testing step for the build. It doesn't put anything into the actual coreboot SDK image. I'd really rather this were left in the test step. If you want to put the entire test step into a separate dockerfile, I'd be okay with that.
The coreboot SDK is used to build more than just coreboot. If you want to create a minimal image that only works to build coreboot as coreboot-tiny-sdk or something that's fine too. Then we can add things on top of that to make this coreboot-sdk image. But let's not change something that works.
-
Martin L Roth (Code Review)