Change in coreboot[master]: soc/amd/picasso: add UPD for RV2 USB3 phy setting adjust - coreboot-gerrit

4 Feb 2021


      Attention is currently required from: Kevin Chiu, Martin Roth, Felix Held.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50240 )
Change subject: soc/amd/picasso: add UPD for RV2 USB3 phy setting adjust
......................................................................
Patch Set 10:
(1 comment)
File src/mainboard/google/zork/variants/baseboard/devicetree_dalboz.cb:
https://review.coreboot.org/c/coreboot/+/50240/comment/534c6202_9d55986a 
PS10, Line 138: "0"
...
Does this need to be 1?  If it's 0, nothing gets updated, right?
Yes, it can be setting in the variant, but for dalboz or trembyle Dali. it will use the default value.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50240
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d5f69e840952cc5171af1ce8597628d1bede5cb
Gerrit-Change-Number: 50240
Gerrit-PatchSet: 10
Gerrit-Owner: chris wang Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 04 Feb 2021 18:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment