Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52765 )
Change subject: device: Switch pci_dev_is_wake_source to take pci_devfn_t ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52765/comment/148c36b6_48f63e64 PS1, Line 15: entire devicetree from SMM (only usage left : is when disabling HECI via SMM)
This change seems fine. […]
Agreed, non-ramstage stages should not need the full topology, just (potentially) the list and/or configs. This change does eliminate 909% of the devicetree for SMM, the only remaining part in SMM is https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... et al.
File src/soc/intel/alderlake/elog.c:
https://review.coreboot.org/c/coreboot/+/52765/comment/db21aacd_28b7ee26 PS1, Line 51: pci_dev_is_wake_source(pme_map[i].devfn)
I don't think this usage is correct. […]
Oh you're right, these devfns always get me all confused 💩