Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40478 )
Change subject: soc/intel/tigerlake: Add method to look up GPIO com ID for an index
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40478/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40478/2//COMMIT_MSG@9
PS2, Line 9: GPID
Was this "GPID" on purpose, or should it have been "GPIO"?
Was the first "GPIO" meant to be "GPID", the name of the function, and the "GPID" meant to be "GPIO?
https://review.coreboot.org/c/coreboot/+/40478/2//COMMIT_MSG@17
PS2, Line 17: BUILD
?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40478
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6a00fb8adef0285d6bbc35cd5a44539bd3be6b8
Gerrit-Change-Number: 40478
Gerrit-PatchSet: 2
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 22 Apr 2020 19:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment