Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40481 )
Change subject: mb/ocp/tiogapass: Implement port 80h direct to GPIO and init UART pins
......................................................................
Patch Set 2:
(1 comment)
Patch Set 2:
(5 comments)
Patch Set 1:
(6 comments)
I've updated.
https://review.coreboot.org/c/coreboot/+/40481/1/src/mainboard/ocp/tiogapass...
File src/mainboard/ocp/tiogapass/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40481/1/src/mainboard/ocp/tiogapass...
PS1, Line 67: gpio_dev
Do you need the variable?
It's constant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40481
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I087d5a81b881533b4550c193e4e9720a134fb8e7
Gerrit-Change-Number: 40481
Gerrit-PatchSet: 2
Gerrit-Owner: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 17 Apr 2020 10:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment