Change in coreboot[master]: src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU

[Prasun Gera (Code Review)]

Prasun Gera has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35431 )

Change subject: src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU
......................................................................

src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU

Both T530 and W530 share the same PCI device id of 0166 for the iGPU.

Change-Id: Idce809e3820a653144db424aff1c55b70c4c693a
Signed-off-by: Prasun Gera 
---
M src/mainboard/lenovo/t530/Kconfig
1 file changed, 5 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/35431/1

diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index f63a120..4fcbcb5 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -60,7 +60,10 @@

config VGA_BIOS_FILE
    string
-	default "pci8086,0106.rom" if BOARD_LENOVO_T530
-	default "pci8086,0166.rom" if BOARD_LENOVO_W530
+	default "pci8086,0166.rom"
+
+config VGA_BIOS_ID
+	string
+	default "8086,0166"

endif

[Peter Lemenkov (Code Review)]

Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35431 )

Change subject: src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU
......................................................................

Patch Set 1: Code-Review+1

That's true according to data from https://github.com/linuxhw/LsPCI/tree/master/Notebook/Lenovo/ThinkPad.

```
Sulaco ~/work/LsPCI/Notebook/Lenovo/ThinkPad (git::master): grep -h -R -o -P "(?<=Graphics Controller )([[0-9]{4}:[0-9]{4}])\s" ThinkPad\ [TW]530\ * | uniq
[8086:0166] 
Sulaco ~/work/LsPCI/Notebook/Lenovo/ThinkPad (git::master)
```

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35431 )

Change subject: src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35431 )

Change subject: src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU
......................................................................

src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU

Both T530 and W530 share the same PCI device id of 0166 for the iGPU.

Change-Id: Idce809e3820a653144db424aff1c55b70c4c693a
Signed-off-by: Prasun Gera 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35431
Tested-by: build bot (Jenkins) 
Reviewed-by: Peter Lemenkov 
Reviewed-by: Patrick Georgi 
---
M src/mainboard/lenovo/t530/Kconfig
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Peter Lemenkov: Looks good to me, but someone else must approve

diff --git a/src/mainboard/lenovo/t530/Kconfig b/src/mainboard/lenovo/t530/Kconfig
index d1ba6a8..04b7528 100644
--- a/src/mainboard/lenovo/t530/Kconfig
+++ b/src/mainboard/lenovo/t530/Kconfig
@@ -60,7 +60,10 @@

config VGA_BIOS_FILE
    string
-	default "pci8086,0106.rom" if BOARD_LENOVO_T530
-	default "pci8086,0166.rom" if BOARD_LENOVO_W530
+	default "pci8086,0166.rom"
+
+config VGA_BIOS_ID
+	string
+	default "8086,0166"

endif

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35431 )

Change subject: src/mainboard/lenovo/t530/Kconfig: Fix PCI device id for the iGPU
......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1108
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1107
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1106

Please note: This test is under development and might not be accurate at all!