Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44160 )
Change subject: cpu/intel/haswell: Select ASAN_IN_ROMSTAGE ......................................................................
cpu/intel/haswell: Select ASAN_IN_ROMSTAGE
ASan in romstage is disabled by default. So, enable it when ASan is selected.
Tested on Lenovo ThinkPad T440P
Change-Id: I6eae242c71f41c9159658ae68d61b4036ad42d42 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/cpu/intel/haswell/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/44160/1
diff --git a/src/cpu/intel/haswell/Kconfig b/src/cpu/intel/haswell/Kconfig index 54cb99f..0d78a75 100644 --- a/src/cpu/intel/haswell/Kconfig +++ b/src/cpu/intel/haswell/Kconfig @@ -22,6 +22,7 @@ select PARALLEL_MP select CPU_INTEL_COMMON select CPU_INTEL_COMMON_TIMEBASE + select ASAN_IN_ROMSTAGE if ASAN_IN_RAMSTAGE
config SMM_TSEG_SIZE hex
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44160 )
Change subject: cpu/intel/haswell: Select ASAN_IN_ROMSTAGE ......................................................................
Patch Set 1: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44160 )
Change subject: cpu/intel/haswell: Select ASAN_IN_ROMSTAGE ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44160/1//COMMIT_MSG@9 PS1, Line 9: ASan … in ramstage
https://review.coreboot.org/c/coreboot/+/44160/1//COMMIT_MSG@10 PS1, Line 10: is selected. … as it has been tested.
https://review.coreboot.org/c/coreboot/+/44160/1/src/cpu/intel/haswell/Kconf... File src/cpu/intel/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/44160/1/src/cpu/intel/haswell/Kconf... PS1, Line 25: select ASAN_IN_ROMSTAGE if ASAN_IN_RAMSTAGE I think a new symbol
SUPPORT_ASAN_IN_ROMSTAGE
should be used.
Hello build bot (Jenkins), Patrick Georgi, Angel Pons, Werner Zeh, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44160
to look at the new patch set (#2).
Change subject: cpu/intel/haswell: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
cpu/intel/haswell: Select HAVE_ASAN_IN_ROMSTAGE
Enable ASan in romstage for haswell as it has been tested on Lenovo ThinkPad T440P.
Change-Id: I6eae242c71f41c9159658ae68d61b4036ad42d42 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/cpu/intel/haswell/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/44160/2
Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44160 )
Change subject: cpu/intel/haswell: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44160/1//COMMIT_MSG@9 PS1, Line 9: ASan
… in ramstage
Done
https://review.coreboot.org/c/coreboot/+/44160/1//COMMIT_MSG@10 PS1, Line 10: is selected.
… as it has been tested.
Done
https://review.coreboot.org/c/coreboot/+/44160/1/src/cpu/intel/haswell/Kconf... File src/cpu/intel/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/44160/1/src/cpu/intel/haswell/Kconf... PS1, Line 25: select ASAN_IN_ROMSTAGE if ASAN_IN_RAMSTAGE
I think a new symbol […]
Done
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44160 )
Change subject: cpu/intel/haswell: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44160 )
Change subject: cpu/intel/haswell: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
cpu/intel/haswell: Select HAVE_ASAN_IN_ROMSTAGE
Enable ASan in romstage for haswell as it has been tested on Lenovo ThinkPad T440P.
Change-Id: I6eae242c71f41c9159658ae68d61b4036ad42d42 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44160 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/cpu/intel/haswell/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/cpu/intel/haswell/Kconfig b/src/cpu/intel/haswell/Kconfig index 18fc392..fe0b9a7 100644 --- a/src/cpu/intel/haswell/Kconfig +++ b/src/cpu/intel/haswell/Kconfig @@ -21,6 +21,7 @@ select PARALLEL_MP select CPU_INTEL_COMMON select CPU_INTEL_COMMON_TIMEBASE + select HAVE_ASAN_IN_ROMSTAGE
config SMM_TSEG_SIZE hex
-
Angel Pons (Code Review) -
Harshit Sharma (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Werner Zeh (Code Review)