Change in coreboot[master]: mb/google/puff: configure USB PLD groups

[Peter Marheine (Code Review)]

Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40516 )

Change subject: mb/google/puff: configure USB PLD groups
......................................................................

mb/google/puff: configure USB PLD groups

Each physical port should have the same group and position for both USB2
and USB3, but puff and its variants use different layout than the
baseboard so they must override PLD.

Ports are split into two groups for front and back, with positions in
each group numbered from left to right.

BUG=b:151579409
BRANCH=none
TEST=PLD_GroupToken and PLD_GroupPosition are set as expected in SSDT.

Change-Id: Ibe19e4faa1fbc7117687d789e9bd5584852a48c0
Signed-off-by: Peter Marheine 
---
M src/mainboard/google/hatch/variants/duffy/overridetree.cb
M src/mainboard/google/hatch/variants/kaisa/overridetree.cb
M src/mainboard/google/hatch/variants/puff/overridetree.cb
3 files changed, 36 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/40516/1

diff --git a/src/mainboard/google/hatch/variants/duffy/overridetree.cb b/src/mainboard/google/hatch/variants/duffy/overridetree.cb
index 3507e6d..2f36bc8 100644
--- a/src/mainboard/google/hatch/variants/duffy/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/duffy/overridetree.cb
@@ -191,31 +191,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 2.5 on end
    				end
    				chip drivers/usb/acpi
@@ -224,31 +230,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 3.5 on end
    				end
    			end
diff --git a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb
index e09d0c4..db05302 100644
--- a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb
@@ -191,31 +191,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 2.5 on end
    				end
    				chip drivers/usb/acpi
@@ -224,31 +230,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 3.5 on end
    				end
    			end
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb
index 3507e6d..2f36bc8 100644
--- a/src/mainboard/google/hatch/variants/puff/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb
@@ -191,31 +191,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 2.5 on end
    				end
    				chip drivers/usb/acpi
@@ -224,31 +230,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 3.5 on end
    				end
    			end

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40516 )

Change subject: mb/google/puff: configure USB PLD groups
......................................................................

Patch Set 1: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40516 )

Change subject: mb/google/puff: configure USB PLD groups
......................................................................

Patch Set 1: Code-Review+1

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40516 )

Change subject: mb/google/puff: configure USB PLD groups
......................................................................

mb/google/puff: configure USB PLD groups

Each physical port should have the same group and position for both USB2
and USB3, but puff and its variants use different layout than the
baseboard so they must override PLD.

Ports are split into two groups for front and back, with positions in
each group numbered from left to right.

BUG=b:151579409
BRANCH=none
TEST=PLD_GroupToken and PLD_GroupPosition are set as expected in SSDT.

Change-Id: Ibe19e4faa1fbc7117687d789e9bd5584852a48c0
Signed-off-by: Peter Marheine 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/40516
Tested-by: build bot (Jenkins) 
Reviewed-by: Edward O'Callaghan 
Reviewed-by: Paul Menzel 
---
M src/mainboard/google/hatch/variants/duffy/overridetree.cb
M src/mainboard/google/hatch/variants/kaisa/overridetree.cb
M src/mainboard/google/hatch/variants/puff/overridetree.cb
3 files changed, 36 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Edward O'Callaghan: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/variants/duffy/overridetree.cb b/src/mainboard/google/hatch/variants/duffy/overridetree.cb
index 3507e6d..2f36bc8 100644
--- a/src/mainboard/google/hatch/variants/duffy/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/duffy/overridetree.cb
@@ -191,31 +191,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 2.5 on end
    				end
    				chip drivers/usb/acpi
@@ -224,31 +230,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 3.5 on end
    				end
    			end
diff --git a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb
index e09d0c4..db05302 100644
--- a/src/mainboard/google/hatch/variants/kaisa/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/kaisa/overridetree.cb
@@ -191,31 +191,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 2.5 on end
    				end
    				chip drivers/usb/acpi
@@ -224,31 +230,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 3.5 on end
    				end
    			end
diff --git a/src/mainboard/google/hatch/variants/puff/overridetree.cb b/src/mainboard/google/hatch/variants/puff/overridetree.cb
index 3507e6d..2f36bc8 100644
--- a/src/mainboard/google/hatch/variants/puff/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/puff/overridetree.cb
@@ -191,31 +191,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 2.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-C Port Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 2.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Front Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 2.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Right""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 2.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 2.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB2 Type-A Rear Left""
    					register "type" = "UPC_TYPE_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 2.5 on end
    				end
    				chip drivers/usb/acpi
@@ -224,31 +230,37 @@
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 0)"
    					device usb 3.0 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Front Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(0, 1)"
    					device usb 3.1 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Right""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 2)"
    					device usb 3.2 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-C Rear""
    					register "type" = "UPC_TYPE_C_USB2_SS_SWITCH"
+						register "group" = "ACPI_PLD_GROUP(1, 3)"
    					device usb 3.3 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Left""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 0)"
    					device usb 3.4 on end
    				end
    				chip drivers/usb/acpi
    					register "desc" = ""USB3 Type-A Rear Middle""
    					register "type" = "UPC_TYPE_USB3_A"
+						register "group" = "ACPI_PLD_GROUP(1, 1)"
    					device usb 3.5 on end
    				end
    			end