Change in ...coreboot[master]: cpu/intel: Configure IA32_FEATURE_CONTROL for alternative SMRR
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27586 )
Change subject: cpu/intel: Configure IA32_FEATURE_CONTROL for alternative SMRR ......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/#/c/27586/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/27586/26//COMMIT_MSG@14 PS26, Line 14: the possibility to not lock VMX
set_vmx_and_lock() is still called, just from somewhere else. […]
CONFIG_ENABLE_VMX is separate from CONFIG_SET_IA32_FC_LOCK_BIT.
The option to (not) lock VMX with CONFIG_SET_IA32_FC_LOCK_BIT is still there for CPU's not supporting SMRR or don't need the SMRR_ENABLE bit in IA32_FEATURE_CONTROL. It might be confusing however... Should I select CONFIG_SET_IA32_FC_LOCK_BIT in the CPU Kconfig?
-
Arthur Heymans (Code Review)