Attention is currently required from: Paul Menzel, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59799 )
Change subject: mb/google/brya/var/felwinter: Swap TPM and touchscreen I2C bus
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brya/variants/felwinter/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59799/comment/41135934_4b88d2f3
PS1, Line 68: }"
That seems to do more than the commit message summary says? (More than just swapping the busses?)
Since the I2C bus information changed, this common SoC config can't be derived from the baseboard anymore, so it has to be moved here as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic05843487ea540b8cd9a50d5f73803905fd80d49
Gerrit-Change-Number: 59799
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 17:35:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment