Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44814 )
Change subject: Documentation: Add ASan documentation ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Thank you Harshit, this makes it more clear. Just a few small things left before we merge this part.
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/asa... File Documentation/technotes/asan.md:
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/asa... PS6, Line 156: Let's subtract the : start address of the stage from `ip` For this, the start address of the stage is missing in your text, or? This address depends on where the stage relocator has put the entire stage at in the DRAM and is shown in the log. You should add this information here in order to allow the reader to follow your computation.
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/asa... PS6, Line 205: we We (Start uppercase after the "Voilà!"?)
https://review.coreboot.org/c/coreboot/+/44814/6/Documentation/technotes/asa... PS6, Line 298: Extra white space.
-
Werner Zeh (Code Review)