Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28743 )
Change subject: soc/intel/cannonlake: Add ACPI entry for LAN ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28743/1/src/soc/intel/cannonlake/acpi/pch_gl... File src/soc/intel/cannonlake/acpi/pch_glan.asl:
https://review.coreboot.org/#/c/28743/1/src/soc/intel/cannonlake/acpi/pch_gl... PS1, Line 28: Method (_DSW, 3) {
We shouldn't need this method if it doesn't exist right? […]
Yes _DSW is optional, for SOC point of view, we can leave it here in case any platform special action can be done from mainboard side. Windows device manager will hide/unhide power management tab with or without _PRW. But not too sure about _DSW
-
Lijian Zhao (Code Review)