Attention is currently required from: Angel Pons.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87404?usp=email )
Change subject: mb/samsung/stumpy: Use CFR setup menu to manage options ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/samsung/stumpy/Kconfig:
https://review.coreboot.org/c/coreboot/+/87404/comment/0ec4d3a7_e90dbde5?usp... : PS2, Line 35: config UEFI_CFR_SYSTEM_OPTIONS : bool "Use UEFI setup menu to manage system configuration" : select DRIVERS_EFI_VARIABLE_STORE : select DRIVERS_OPTION_CFR : select UDK_2017_BINDING : default y if PAYLOAD_EDK2 && SMMSTORE : default n :
Oh, the idea to handle bindings would be to have something like `select UDK_2017_BINDING if DRIVERS_ […]
how about: ``` config DRIVERS_EFI_VARIABLE_STORE bool "Include EFI variable store driver" + select UDK_2017_BINDING if !PLATFORM_USES_FSP2_0 - depends on UDK_BASE help ``` that would ensure `UDK_BASE` is always selected. And maybe: ``` config DRIVERS_OPTION_CFR bool "Support generating a CFR list of options" + select DRIVERS_EFI_VARIABLE_STORE if PAYLOAD_EDK2 && SMMSTORE default y if DRIVERS_OPTION_CFR_ENABLED ``` Thoughts?